Mark, Gary and I had talked about only the Quantum-side change yesterday. We were on the fence due to the volume of code change, but decided that we could go forward.<div><br></div><div>The ugliness of the Nova-side changes kind of tip the balance in my mind against putting this in stable/folsom. While the proposal of a new vif-driver would work, I think that Daniel is right in saying that we are in this problematic situation b/c this is really a small feature masquerading as a bug-fix. This wouldn't be the first time a small feature is pushed into a stable branch, but I think we all need to be convinced that it is a big win in order to do so.</div>
<div><br></div><div>Dan</div><div><br></div><div><br></div><div><br><br><div class="gmail_quote">On Wed, Nov 28, 2012 at 9:36 AM, Daniel P. Berrange <span dir="ltr"><<a href="mailto:berrange@redhat.com" target="_blank">berrange@redhat.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Wed, Nov 28, 2012 at 05:31:25PM +0000, Mark McLoughlin wrote:<br>
> On Wed, 2012-11-28 at 17:22 +0000, Daniel P. Berrange wrote:<br>
> > On Wed, Nov 28, 2012 at 05:17:09PM +0000, Mark McLoughlin wrote:<br>
> > > Hey,<br>
> > ><br>
> > > On Wed, 2012-11-28 at 12:21 +0200, Gary Kotton wrote:<br>
> > > > Hi,<br>
> > > > There is valid concern about the upgrade procedure with this patch.<br>
> > > > There is a way that we are able to do this without creating an major<br>
> > > > problems:<br>
> > > > 1. Leave the class QuantumLinuxBridgeVIFDriver unchanged<br>
> > > > 2. Add in a new class QuantumLinuxBridgeVIFDriverEnhanced (or if someone<br>
> > > > has a better name). This class will contain the changes. If someone<br>
> > > > wants to benefit fro the changes then she/he will need to update their<br>
> > > > configuration file to:<br>
> > > ><br>
> > > > libvirt_vif_driver=nova.virt.libvirt.vif.QuantumLinuxBridgeVIFDriverEnhanced<br>
> > > > This can be documented and it may treat all of the concerns. Naturally a<br>
> > > > patch upstream will need to be added so that this wil be forward compatible.<br>
> > ><br>
> > > Yeah, I think this would work well - linuxbridge users are no longer<br>
> > > required to update Quantum before Nova, they just need to update Quantum<br>
> > > before using the new VIF driver.<br>
> > ><br>
> > > So, yep - go for it IMHO. It'll have to wait until after 2012.2.1 though<br>
> > > and will have to happen on master too.<br>
> ><br>
> > I don't much like that we'd be supporting this duplicate class<br>
> > in Grizzly too. IMHO it is right that users of the existing<br>
> > code on Folsom, automatically get the new code when switching<br>
> > to Grizzly with no re-configuration.<br>
><br>
> Fair, but the new class name that we add to the Folsom branch needs to<br>
> continue to work when people update to Grizzly.<br>
><br>
> i.e. two classes that do the same thing on Grizzly, but do different<br>
> things on Folsom<br>
<br>
</div></div>IMHO we're just creating this problem for ourselves by pushing something<br>
which is not really a bugfix into stable. Although the current code is<br>
suboptimal, it does still work for Folsom & people can wait till Grizzly<br>
for the re-designed code.<br>
<div class="im HOEnZb"><br>
Daniel<br>
--<br>
|: <a href="http://berrange.com" target="_blank">http://berrange.com</a> -o- <a href="http://www.flickr.com/photos/dberrange/" target="_blank">http://www.flickr.com/photos/dberrange/</a> :|<br>
|: <a href="http://libvirt.org" target="_blank">http://libvirt.org</a> -o- <a href="http://virt-manager.org" target="_blank">http://virt-manager.org</a> :|<br>
|: <a href="http://autobuild.org" target="_blank">http://autobuild.org</a> -o- <a href="http://search.cpan.org/~danberr/" target="_blank">http://search.cpan.org/~danberr/</a> :|<br>
|: <a href="http://entangle-photo.org" target="_blank">http://entangle-photo.org</a> -o- <a href="http://live.gnome.org/gtk-vnc" target="_blank">http://live.gnome.org/gtk-vnc</a> :|<br>
<br>
</div><div class="HOEnZb"><div class="h5">_______________________________________________<br>
Openstack-stable-maint mailing list<br>
<a href="mailto:Openstack-stable-maint@lists.openstack.org">Openstack-stable-maint@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-stable-maint</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>Dan Wendlandt <div>Nicira, Inc: <a href="http://www.nicira.com" target="_blank">www.nicira.com</a><br><div>twitter: danwendlandt<br>
~~~~~~~~~~~~~~~~~~~~~~~~~~~<br></div></div><br>
</div>