Open Stack

2013/5/7 John Griffith <john.griffith at solidfire.com>:
> On Mon, May 6, 2013 at 7:44 PM, Adam Gandelman <adamg at canonical.com> wrote:
>> I'm probably being a stickler, and I trust John's judgment on proposing
>> the patches as-is, but I'm a bit concerned about the following:

Thanks for the feedback Adam, that's why I said I want to see one more
review before approving.

> https://review.openstack.org/#/c/28207/
>  is the Cherry Pick and was in fact intended to include a fix for both
> items.  In the future we (the Cinder team and more specifically me) should
> probably be better about separate commits for separate issues.  That being

Definitely, when you're fixing an issue on master which is already
tagged for backport in Launchpad, please do separate commits.

> said it's basically a one line change that needed to be made so it was
> included, but the issue here is the commit to master and not the commit to
> stable.
>
>
> https://review.openstack.org/#/c/28210/
> is another story, and I agree the addition of the fix to the formatting of
> the log messages should probably not be included.  It started off as a
> single log entry with a misspelling that earned it a -1 in the review and
> then as we looked closer we found more and more typos and formatting issues
> in the log statements.  It's safe as it's isolated to the logging output,
> however you're probably right that it should not be in this particular
> patch.  I'm happy to remove those *extras* and resubmit.

Yes, please resubmit only critical fix, as request by Adam. I'm not
that concerned since changes looked sane and are localized in one
driver only. Diverging from master is bad for future backports, but
since we want to release in 2 days, let's make minimal change now and
sync-up stable with master later if/when further backports are needed.

Thanks,
Alan