Open Stack

Alan Pevec <apevec at gmail.com> writes:

> Dana 23. 12. 2012. 07:23 "Gary Kotton" <gkotton at redhat.com> je napisao:
>> A few days ago the pep8 version on the CI servers was updated. This
> causes patches in the Quantum stable branch to fail (not sure what the
> situation is with the other projects). Can you please take a look at
> https://review.openstack.org/18594.
>
> Not sure if that's a good idea for a stable branch.
> Instead of that, you cloud consider fixing pep8 version in test-requires,
> e.g. Keystone has pep8==1.3.3

Indeed.  The pep8 tool is not installed on Jenkins nodes, but rather
whatever version is specified in each project's tox.ini is installed in
the tox virtualenv for testing.  Like all project-level tests, you can
run the exact same setup on your workstation with:

  tox -e pep8

At the Grizzly summit, folks agreed that projects should choose a pep8
version early in the cycle and pin it.  To be effective, pep8 actually
needs to be pinned in tox.ini.  Here is a change that does it for
stable/folsom:

  https://review.openstack.org/#/c/18599/

You may want to make a similar change for master.

-Jim