[Openstack-security] [openstack/oslo-incubator] SecurityImpact review request change I3b49b1d667f6ade9ae3f6765d735440a3e838917

gerrit2 at review.openstack.org gerrit2 at review.openstack.org
Sat Sep 13 17:31:37 UTC 2014


Hi, I'd like you to take a look at this patch for potential
SecurityImpact.
https://review.openstack.org/121365

Log:
commit d54b4dc1597dd3baee3c934face55d98028a79a3
Author: Tristan Cacqueray <tristan.cacqueray at enovance.com>
Date:   Thu Sep 11 16:31:24 2014 +0000

    Fix password leak from ProcessExecution errors
    
    This backport required changes to fix both issues:
    * Make execute method clean password in exception
    * Make sure mask_password works properly
    
    This backport is not trivial as these fixes relies on many other
    changes, only the necessary code have been imported/adapted.
    
    ------------------------------------------------
    The sync pulls in the following changes (newest to oldest):
    
    63c99a0f - Mask passwords in exceptions and error messages
    66142c34 - Make strutils.mask_password more secure
    d6b55fb2 - Remove `processutils` dependency on `log`
    cb5a804b - Move `mask_password` to strutils
    
    -----------------------------------------------
    
    Closes-Bug: 1343604
    Closes-Bug: 1345233
    SecurityImpact
    
    Conflicts:
    	openstack/common/processutils.py
    	tests/unit/test_strutils.py
    
    Change-Id: I3b49b1d667f6ade9ae3f6765d735440a3e838917
    (cherry picked from commit 4cf1a2a158f7c3c21799bf2e6ba0e7b5fbc25d62)





More information about the Openstack-security mailing list