[Openstack-security] [openstack/nova] SecurityImpact review request change I10ec97c6e502c9799672cf2df50e3a0f65b679a9
gerrit2 at review.openstack.org
gerrit2 at review.openstack.org
Thu Mar 27 14:58:11 UTC 2014
Hi, I'd like you to take a look at this patch for potential
SecurityImpact.
https://review.openstack.org/83413
Log:
commit c21acacad9220e27b0fe718599eba40f44187f5a
Author: David Ripton <dripton at redhat.com>
Date: Tue Jan 28 16:38:51 2014 -0500
Persist image format to a file, to prevent attacks based on changing it
The attack is based on creating a raw image that looks like a qcow2
image, and taking advantage of the code that used 'qemu-img info' to
autodetect the image format.
Now we store the image format to a 'disk.info' file, for Qcow2 and Raw
images, and only autodetect for images that have never been written to
that file.
SecurityImpact
Conflicts:
nova/virt/libvirt/imagebackend.py
Manual tweaks to some mocking in test_imagebackend.py
Change-Id: I10ec97c6e502c9799672cf2df50e3a0f65b679a9
Co-authored-by: Nikola Dipanov <ndipanov at redhat.com>
Closes-bug: #1221190
More information about the Openstack-security
mailing list