[Openstack-security] [Bug 1289195] Re: Duplicate security group name cause fail to start instance

Xurong Yang yangxurong at huawei.com
Wed Mar 12 08:43:24 UTC 2014


It should be using UUID instead of 'name' such as network_id port_id as
name(not the key) can't differentiate security groups. so i think we
should fix it in nova.

** Also affects: nova
   Importance: Undecided
       Status: New

** Changed in: nova
     Assignee: (unassigned) => Xurong Yang (idopra)

** Changed in: nova
       Status: New => In Progress

** Changed in: neutron
       Status: Opinion => Invalid

-- 
You received this bug notification because you are a member of OpenStack
Security Group, which is subscribed to OpenStack.
https://bugs.launchpad.net/bugs/1289195

Title:
  Duplicate security group name cause fail to start instance

Status in OpenStack Neutron (virtual network service):
  Invalid
Status in OpenStack Compute (Nova):
  In Progress

Bug description:
  When create a security group, the duplicate name is allowed.
  In create a instance, duplicate sg name will cause exception and the instance will be started fail. So the duplicate name of sg should be not allowed.

  In nova.network.neutronv2.API:allocate_for_instance
  for security_group in security_groups:
      name_match = None
      uuid_match = None
      for user_security_group in user_security_groups:
          if user_security_group['name'] == security_group:         # if have duplicate sg name, the name_match will not be None for the second matching.
              if name_match:
                  raise exception.NoUniqueMatch(
                      _("Multiple security groups found matching"
                         " '%s'. Use an ID to be more specific.") %
                      security_group)

              name_match = user_security_group['id']
          if user_security_group['id'] == security_group:
              uuid_match = user_security_group['id']

To manage notifications about this bug go to:
https://bugs.launchpad.net/neutron/+bug/1289195/+subscriptions




More information about the Openstack-security mailing list