<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; color: rgb(0, 0, 0); font-size: 14px; font-family: Calibri, sans-serif;">
<div>
<div>If we are going to be stringent on formatting – I would also like to see us be relatively consistent on arguments/env variables that are needed to make a script run. Some pull in ENV vars, some source a rc file, some just say already source your rc file
to start with, others accept command options. It would be nice if we had a set of curated scripts that all worked in a similar fashion.</div>
<div><br>
</div>
<div>Also, to Joe's point. It would be nice if we had two place for scripts. A "dumping ground" that people could share what they had. And a curated one, where everything within the curated repo follows a standard set of conventions/guidelines. </div>
<div>
<div id="MAC_OUTLOOK_SIGNATURE">
<div><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" face="Calibri"><span class="Apple-style-span" style="font-size: 14px;"><br>
</span></font></font></div>
<div><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" face="Calibri"><span class="Apple-style-span" style="font-size: 14px;">___________________________________________________________________</span></font></font></div>
<div><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" face="Calibri"><span class="Apple-style-span" style="font-size: 14px;">Kris Lindgren</span></font></font></div>
<div><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" face="Calibri"><span class="Apple-style-span" style="font-size: 14px;">Senior Linux Systems Engineer</span></font></font></div>
<div><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" face="Calibri"><span class="Apple-style-span" style="font-size: 14px;">GoDaddy</span></font></font></div>
</div>
</div>
</div>
<div><br>
</div>
<span id="OLK_SRC_BODY_SECTION">
<div style="font-family:Calibri; font-size:12pt; text-align:left; color:black; BORDER-BOTTOM: medium none; BORDER-LEFT: medium none; PADDING-BOTTOM: 0in; PADDING-LEFT: 0in; PADDING-RIGHT: 0in; BORDER-TOP: #b5c4df 1pt solid; BORDER-RIGHT: medium none; PADDING-TOP: 3pt">
<span style="font-weight:bold">From: </span>Joe Topjian<br>
<span style="font-weight:bold">Date: </span>Tuesday, September 29, 2015 at 1:43 PM<br>
<span style="font-weight:bold">To: </span>JJ Asghar<br>
<span style="font-weight:bold">Cc: </span>"<a href="mailto:openstack-operators@lists.openstack.org">openstack-operators@lists.openstack.org</a>"<br>
<span style="font-weight:bold">Subject: </span>Re: [Openstack-operators] [openstack-operators][osops] Something other than NOOP in our jenkins tests<br>
</div>
<div><br>
</div>
<div>
<div>
<div dir="ltr">So this will require bash scripts to adhere to bashate before being accepted? Is it possible to have the check as non-voting? Does this open the door to having other file types be checked?
<div><br>
</div>
<div>IMHO, it's more important for the OSOps project to foster collaboration and contributions rather than worry about an accepted style.
<div><br>
</div>
<div>As an example, yesterday's commits used hard-tabs:</div>
<div><br>
</div>
<div><a href="https://review.openstack.org/#/c/228545/">https://review.openstack.org/#/c/228545/</a><br>
</div>
<div><a href="https://review.openstack.org/#/c/228534/">https://review.openstack.org/#/c/228534/</a><br>
</div>
<div><br>
</div>
<div>I think we're going to see a lot of variation of styles coming in.</div>
<div><br>
</div>
<div>I don't want to come off as sounding ignorant or disrespectful to other projects that have guidelines in place -- I fully understand and respect those decisions.<br>
</div>
<div><br>
</div>
<div>Joe</div>
</div>
</div>
<div class="gmail_extra"><br>
<div class="gmail_quote">On Tue, Sep 29, 2015 at 12:52 PM, JJ Asghar <span dir="ltr">
<<a href="mailto:jj@chef.io" target="_blank">jj@chef.io</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Awesome! That works!<br>
<span class="im HOEnZb"><br>
Best Regards,<br>
JJ Asghar<br>
c: <a href="tel:512.619.0722" value="+15126190722">512.619.0722</a> t: @jjasghar irc: j^2<br>
<br>
</span><span class="im HOEnZb">On 9/29/15 1:27 PM, Christian Berendt wrote:<br>
> On 09/29/2015 07:45 PM, JJ Asghar wrote:<br>
>> So this popped up today[1]. This seems like something that should be<br>
>> leveraged in our gates/validations?<br>
><br>
> I prepared review requests to enable checks on the gates for<br>
><br>
> * osops-tools-monitoring: <a href="https://review.openstack.org/#/c/229094/" rel="noreferrer" target="_blank">
https://review.openstack.org/#/c/229094/</a><br>
> * osops-tools-generic: <a href="https://review.openstack.org/#/c/229043/" rel="noreferrer" target="_blank">
https://review.openstack.org/#/c/229043/</a><br>
><br>
> Christian.<br>
><br>
<br>
<br>
</span>
<div class="HOEnZb">
<div class="h5">_______________________________________________<br>
OpenStack-operators mailing list<br>
<a href="mailto:OpenStack-operators@lists.openstack.org">OpenStack-operators@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-operators</a><br>
</div>
</div>
</blockquote>
</div>
<br>
</div>
</div>
</div>
</span>
</body>
</html>