<div><div dir="auto">I guess that means that you are not against the idea.</div><div dir="auto"><br></div><div dir="auto">Clearly I will wait for the container to be ready in that case. In fact it would be easier to override the file during container building.</div></div><div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, 29 Jan 2020 at 05:15, Ian Wienand <<a href="mailto:iwienand@redhat.com">iwienand@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-style:solid;padding-left:1ex;border-left-color:rgb(204,204,204)">On Fri, Jan 24, 2020 at 09:32:00AM +0000, Sorin Sbarnea wrote:<br>
> We are currently using default Gerrit favicon on<br>
> <a href="https://review.opendev.org" rel="noreferrer" target="_blank">https://review.opendev.org</a> and I would like to propose changing it<br>
> in order to ease differentiation between it and other gerrit servers<br>
> we may work with.<br>
<br>
I did notice google started putting this next to search results<br>
recently too, but then maybe reverted the change.<br>
<br>
> How hard it would be to override it? (where)<br>
<br>
I'm 99% sure it's built-in from [2] and there's no way to runtime<br>
override it.  It looks like for robots.txt we tell the apache that<br>
fronts gerrit to look elsewhere [3]; I imagine the same would need to<br>
be done for favicon.ico.<br>
<br>
... also be aware that upcoming containerisation of gerrit probably<br>
invalidates all that.<br>
<br>
-i<br>
<br>
[1] <a href="https://www.theverge.com/2020/1/24/21080424/google-search-result-ads-desktop-favicon-redesign-backtrack-controversial-experiment" rel="noreferrer" target="_blank">https://www.theverge.com/2020/1/24/21080424/google-search-result-ads-desktop-favicon-redesign-backtrack-controversial-experiment</a><br>
[2] <a href="https://opendev.org/opendev/gerrit/src/branch/openstack/2.13.12/gerrit-war/src/main/webapp" rel="noreferrer" target="_blank">https://opendev.org/opendev/gerrit/src/branch/openstack/2.13.12/gerrit-war/src/main/webapp</a><br>
[3] <a href="https://opendev.org/opendev/puppet-gerrit/src/branch/master/templates/gerrit.vhost.erb#L71" rel="noreferrer" target="_blank">https://opendev.org/opendev/puppet-gerrit/src/branch/master/templates/gerrit.vhost.erb#L71</a><br>
<br>
</blockquote></div></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">--<div>/sorin</div></div></div>