<div dir="ltr">This is a (the?) killer feature.<div><br><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 24, 2018 at 11:33 AM, James E. Blair <span dir="ltr"><<a href="mailto:corvus@inaugust.com" target="_blank">corvus@inaugust.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi,<br>
<br>
We recently introduced a new URL-based syntax for Depends-On: footers<br>
in commit messages:<br>
<br>
Depends-On: <a href="https://review.openstack.org/535851" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>535851</a><br>
<br>
The old syntax will continue to work for a while, but please begin using<br>
the new syntax on new changes.<br>
<br>
Why are we changing this? Zuul has grown the ability to interact with<br>
multiple backend systems (Gerrit, GitHub, and plain Git so far), and we<br>
have extended the cross-repo-dependency feature to support multiple<br>
systems. But Gerrit is the only one that uses the change-id syntax.<br>
URLs, on the other hand, are universal.<br>
<br>
That means you can write, as in <a href="https://review.openstack.org/535541" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>535541</a>, a<br>
commit message such as:<br>
<br>
Depends-On: <a href="https://github.com/ikalnytskyi/sphinxcontrib-openapi/pull/17" rel="noreferrer" target="_blank">https://github.com/<wbr>ikalnytskyi/sphinxcontrib-<wbr>openapi/pull/17</a><br>
<br>
Or in a Github pull request like<br>
<a href="https://github.com/ansible/ansible/pull/20974" rel="noreferrer" target="_blank">https://github.com/ansible/<wbr>ansible/pull/20974</a>, you can write:<br>
<br>
Depends-On: <a href="https://review.openstack.org/536159" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>536159</a><br>
<br>
But we're getting a bit ahead of ourselves here -- we're just getting<br>
started with Gerrit <-> GitHub dependencies and we haven't worked<br>
everything out yet. While you can Depends-On any GitHub URL, you can't<br>
add any project to required-projects yet, and we need to establish a<br>
process to actually report on GitHub projects. But cool things are<br>
coming.<br>
<br>
We will continue to support the Gerrit-specific syntax for a while,<br>
probably for several months at least, so you don't need to update the<br>
commit messages of changes that have accumulated precious +2s. But do<br>
please start using the new syntax now, so that we can age the old syntax<br>
out.<br>
<br>
There are a few differences in using the new syntax:<br>
<br>
* Rather than copying the change-id from a commit message, you'll need<br>
to get the URL from Gerrit. That means the dependent change already<br>
needs to be uploaded. In some complex situations, this may mean that<br>
you need to amend an existing commit message to add in the URL later.<br>
<br>
If you're uploading both changes, Gerrit will output the URL when you<br>
run git-review, and you can copy it from there. If you are looking at<br>
an existing change in Gerrit, you can copy the URL from the permalink<br>
at the top left of the page. Where it says "Change 535855 - Needs<br>
..." the change number itself is the permalink of the change.<br></blockquote><div><br></div><div><br></div><div>Is the permalink the only valid format here for gerrit? Or does the fully</div><div>expanded link also work. E.g.,</div><div><br></div><div> Depends-On: <a href="https://review.openstack.org/536540">https://review.openstack.org/536540</a></div><div><br></div><div>versus</div><div><br></div><div> Depends-On: <a href="https://review.openstack.org/#/c/536540/">https://review.openstack.org/#/c/536540/</a></div><div><br></div><div>[snip]</div><div><br></div><div><br></div><div>-Dave</div></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>David Shrewsbury (Shrews)<br></div></div></div>
</div></div></div>