<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
This patch gives ability to set jenkins_version from
puppet-openstackci<br>
<a class="moz-txt-link-freetext" href="https://review.openstack.org/367232">https://review.openstack.org/367232</a><br>
<br>
<div class="moz-cite-prefix">On 09/07/2016 07:03 PM, Asselin, Ramy
wrote:<br>
</div>
<blockquote
cite="mid:DF4PR84MB00605AFB8D9455A26D91959B8EF80@DF4PR84MB0060.NAMPRD84.PROD.OUTLOOK.COM"
type="cite">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Simon
proposed an updated patch to fix this issue:
<a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/366803/1">https://review.openstack.org/#/c/366803/1</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">
Asselin, Ramy
<br>
<b>Sent:</b> Tuesday, September 06, 2016 2:59 PM<br>
<b>To:</b> <a class="moz-txt-link-abbreviated" href="mailto:li.yuanzhen@zte.com.cn">li.yuanzhen@zte.com.cn</a>; <a class="moz-txt-link-abbreviated" href="mailto:mihailmed@gmail.com">mihailmed@gmail.com</a>;
<a class="moz-txt-link-abbreviated" href="mailto:eantyshev@virtuozzo.com">eantyshev@virtuozzo.com</a>; Thiago Paiva Brito
<a class="moz-txt-link-rfc2396E" href="mailto:thiagop@lsd.ufcg.edu.br"><thiagop@lsd.ufcg.edu.br></a><br>
<b>Cc:</b> <a class="moz-txt-link-abbreviated" href="mailto:openstack-infra@lists.openstack.org">openstack-infra@lists.openstack.org</a><br>
<b>Subject:</b> Re: [OpenStack-Infra] [Zuul] can not get
zuul env variables, such as 'ZUUL_URL'<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Evgeny
was working on getting Jenkins pinned to older working
versions.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">He
ran into some issues posted on the openstack-dev mailing
list [1] where the merged patch doesn’t actually work:
<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[1]
<a moz-do-not-send="true"
href="http://lists.openstack.org/pipermail/openstack-dev/2016-September/102983.html">http://lists.openstack.org/pipermail/openstack-dev/2016-September/102983.html</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">[2]
<a moz-do-not-send="true"
href="https://review.openstack.org/354086">https://review.openstack.org/354086</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif">
<a moz-do-not-send="true"
href="mailto:li.yuanzhen@zte.com.cn">li.yuanzhen@zte.com.cn</a>
[<a moz-do-not-send="true"
href="mailto:li.yuanzhen@zte.com.cn">mailto:li.yuanzhen@zte.com.cn</a>]
<br>
<b>Sent:</b> Monday, September 05, 2016 8:20 PM<br>
<b>To:</b> <a moz-do-not-send="true"
href="mailto:mihailmed@gmail.com">mihailmed@gmail.com</a><br>
<b>Cc:</b> <a moz-do-not-send="true"
href="mailto:openstack-infra@lists.openstack.org">openstack-infra@lists.openstack.org</a><br>
<b>Subject:</b> Re: [OpenStack-Infra] [Zuul] can not get
zuul env variables, such as 'ZUUL_URL'<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><span
style="font-size:10.0pt;font-family:SimSun">Hi Mikhail,</span>
<br>
<br>
<span style="font-size:10.0pt;font-family:SimSun">Very glad to
receive your response. </span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">In my env,
the version of Jenkins is 2.7.2. </span>
<br>
<br>
<br>
<span style="font-size:10.0pt;font-family:SimSun">Now my
Jenkins jobs can get environment variables after I modify my</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">Jenkins env
with your suggestion. </span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">Thank you
very much.</span> <br>
<br>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞Hi Li,</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞On Sun, Sep
4, 2016 at 10:18 AM, ＜li.yuanzhen?zte.com.cn＞ wrote:</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞ Hi all,</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
For deploy CI env, I need a help for Zuul.</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
In the slave node, I can not get the "zuul"</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
environments variables using 'env' shell command,</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
such as 'ZUUL_URL'.</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
The following is the config and log info</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
*) /etc/zuul/layout/zuul.conf:</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
</span><a moz-do-not-send="true"
href="http://paste.ubuntu.com/23132730/"><span
style="font-size:10.0pt;font-family:SimSun">http://paste.ubuntu.com/23132730/</span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
*) /etc/jenkins_jobs/config/citest.yaml</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
</span><a moz-do-not-send="true"
href="http://paste.ubuntu.com/23132723/"><span
style="font-size:10.0pt;font-family:SimSun">http://paste.ubuntu.com/23132723/</span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
*) jenkins job result:</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
</span><a moz-do-not-send="true"
href="http://paste.ubuntu.com/23132737/"><span
style="font-size:10.0pt;font-family:SimSun">http://paste.ubuntu.com/23132737/</span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
*) /var/log/zuul/zuul.log</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
</span><a moz-do-not-send="true"
href="http://paste.ubuntu.com/23132745/"><span
style="font-size:10.0pt;font-family:SimSun">http://paste.ubuntu.com/23132745/</span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
*) /var/log/zuul/merger-debug.log</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
</span><a moz-do-not-send="true"
href="http://paste.ubuntu.com/23132748/"><span
style="font-size:10.0pt;font-family:SimSun">http://paste.ubuntu.com/23132748/</span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
*) /var/log/zuul/debug.log</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
</span><a moz-do-not-send="true"
href="http://paste.ubuntu.com/23132762/"><span
style="font-size:10.0pt;font-family:SimSun">http://paste.ubuntu.com/23132762/</span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞ I
check the zuul code and it has been got the</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
'zuul_url' variables in zuul-mergerr, but in slave nodes,</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
these variables can not be passed by zuul-scheduler.</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞＞
Is there any wrong in my zuul config or jenkins jobs?</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞You might
be affected by the fix to SECURITY-170 [1] in new Jenkins</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞you
installed. It prevents Zuul from passing paramters that are
not</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞white
listed. Which version of Jenkins are you using? Last version</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞without the
security fix is 1.651.1.</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞If you have
later version, you would need to either white list all</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞zuul
variables (</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞-Dhudson.model.ParametersAction.safeParameters=ZUUL_URL,ZUUL_COMMIT
),</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞or disable
that security feature (</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞-Dhudson.model.ParametersAction.keepUndefinedParameters=true
).</span>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞</span> <br>
<span style="font-size:10.0pt;font-family:SimSun">＞[1] </span><a
moz-do-not-send="true"
href="https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170"><span
style="font-size:10.0pt;font-family:SimSun"><a class="moz-txt-link-freetext" href="https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170">https://wiki.jenkins-ci.org/display/JENKINS/Plugins+affected+by+fix+for+SECURITY-170</a></span></a>
<br>
<span style="font-size:10.0pt;font-family:SimSun">＞</span> <o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>