<div dir="ltr">Having lint checks as non-voting seems like a good compromise to me here.</div><div class="gmail_extra"><br><div class="gmail_quote">2015-08-12 17:09 GMT+02:00 Yolanda Robla Mota <span dir="ltr"><<a href="mailto:yolanda.robla-mota@hp.com" target="_blank">yolanda.robla-mota@hp.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi<br>
So my point here, is that i don't want to do a discrimination between rules on puppet<br>
modules and system-config. If we enforce lint rules, we should do it everywhere.<br>
<br>
For lint in system-config, once concern was that it affects history. But as long as we are moving<br>
more functionality to the modules, we have this problem there as well.<br>
<br>
I'd like that we have common lint rules, the same for system-config and for puppet modules.<br>
Maybe a first step is to add lint rules to system-config as non-voting and go gradually iterating<br>
on it?<br>
<br>
That's my take.<br>
<br>
El 12/08/15 a las 16:56, Paul Belanger escribió:<div class="HOEnZb"><div class="h5"><br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Greetings,<br>
<br>
This email comes from some personal frustrations regarding our code review<br>
policy for system-config. Specifically, lint or style checks for puppet code.<br>
<br>
Back in Nov. 30 2012 (yes I checked) I enabled voting for<br>
gate-ci-puppet-lint[1]. It was one of my first efforts for infra :) Since then<br>
we've grown to a large family of puppet contributors.<br>
<br>
However, system-config underwent a change, maybe a year ago, to remove lint<br>
checks. My understanding of the reason to disable the check, was since<br>
system-config was not being uploaded into the puppet forge, there was no need to<br>
have lint checks running.<br>
<br>
About 4-5 months ago, I asked to re-enable the lint check, but we denied.<br>
Comments revolved around git blame / history issue and wasted effort. I don't<br>
have issue with this reasoning, if people don't want to do it, I don't want to<br>
force it.<br>
<br>
However, recently. I got my hand smacked in 2 different code reviews for arrow<br>
alignment issues. Honestly, I wasn't even mad about the -1 for the alignment.<br>
However, I'm concerned about the wasted effort the -1 caused me. Basically, I<br>
had to wait a few days to get the -1, since it was a human doing the review, not<br>
the gate. Additionally, if I was getting a -1 for style checks, why didn't<br>
jenkins do it?<br>
<br>
So, my question is simple. What is our policy on style checks for<br>
system-config. From what I understand, it goes both ways. People don't want<br>
gate checksi (wasted effort), however people are doing human code review for<br>
style checks (because they like unified puppet modules). Needless to say, this<br>
is slightly confusing.<br>
<br>
All and all, I would rather jenkins give me a -1 if my code does not pass style<br>
over a human. Since, I can quickly run my tests locally before uploading into<br>
the gate.<br>
<br>
For the record, I want to re-enable the lint gate for system-config. This keeps<br>
it inline with 99% of our other openstack / openstack-infra puppet modules.<br>
<br>
[1] <a href="https://github.com/openstack-infra/project-config/commit/bee9131dce447d8dd53f246438fd3363a88da426" rel="noreferrer" target="_blank">https://github.com/openstack-infra/project-config/commit/bee9131dce447d8dd53f246438fd3363a88da426</a><br>
<br>
_______________________________________________<br>
OpenStack-Infra mailing list<br>
<a href="mailto:OpenStack-Infra@lists.openstack.org" target="_blank">OpenStack-Infra@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra</a><br>
</blockquote>
<br></div></div><span class="HOEnZb"><font color="#888888">
-- <br>
Yolanda Robla Mota<br>
Cloud Automation and Distribution Engineer<br>
<a href="tel:%2B34%20605641639" value="+34605641639" target="_blank">+34 605641639</a><br>
<a href="mailto:yolanda.robla-mota@hp.com" target="_blank">yolanda.robla-mota@hp.com</a></font></span><div class="HOEnZb"><div class="h5"><br>
<br>
<br>
_______________________________________________<br>
OpenStack-Infra mailing list<br>
<a href="mailto:OpenStack-Infra@lists.openstack.org" target="_blank">OpenStack-Infra@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra</a><br>
</div></div></blockquote></div><br></div>