[OpenStack-Infra] pip-10.0.0 will make tox library in openstack-infra/zuul-jobs won't work

Jeremy Stanley fungi at yuggoth.org
Mon Apr 16 16:08:01 UTC 2018


On 2018-04-16 20:52:22 +0800 (+0800), 张幸 wrote:
> I have noticed that pip release a new version days ago, and when I
> test on my own CI system trigered by job
> openstack-zuul-jobs-linters, there was an error, looks like pip
> version installed in nodepool image is higher the the code need:
> 
> File:
> https://github.com/openstack-infra/zuul-jobs/blob/master/roles/tox/library/tox_install_sibling_packages.py#L114
[...]

Yes, we missed that we were importing from pip's internals here,
even knowing that pip 10 would intentionally break anything that
did. There are a few possibilities:

1. We could temporarily get it from pip._internal.req if we want a
fast stop-gap while discussing more thorough solutions.

2. We could implement our own parse_requirements() based on a
supported API from pkg_resources (like PBR does) or the packaging
library.

3. We can revisit whether we need to perform fancy parsing the `pip
freeze` output at all.

Clark's https://review.openstack.org/561659 is attempting to do #3.
-- 
Jeremy Stanley
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: not available
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20180416/5c818eb5/attachment-0001.sig>


More information about the OpenStack-Infra mailing list