Open Stack

On 05/24/2017 07:04 PM, James E. Blair wrote:
<snip>
> The natural way to identify a GitHub pull request is with its URL.
> 
> This can be used to identify Gerrit changes as well, and will likely be
> well supported by other systems.  Therefore, I propose we support URLs
> as the content of the Depends-On footers for all systems.  E.g.:
> 
>   Depends-On: https://review.openstack.org/12345
>   Depends-On: https://github.com/ansible/ansible/pull/12345
> 
> Similarly to the Gerrit change IDs, these identifiers are easily
> navigable within Gerrit (and Gertty), so that reviewers can traverse the
> dependency chain easily.

Sounds sensible to me. The only thing I ask is that we get a good clock
countdown on when it will be removed. Upgrade testing is one of the
places where the multi branch magic was really useful, so it will take a
little while to get good at it.

For gerrit reviews it should also accept -
https://review.openstack.org/#/c/467243/ (as that's what is in people's
browser url bar).


And while this change is taking place, it would be nice if there was the
ability to have words after the url. I've often wanted:

Depends-On: https://review.openstack.org/12345 - nova
Depends-On: https://review.openstack.org/12346 - python-neutronclient

Just as a quick way to remember, without having to link follow, which of
multiple depends on are which projects. I've resorted to putting them on
top, but for short things would love to have them on the same line.

	-Sean

-- 
Sean Dague
http://dague.net