Open Stack

Hello,

thank for hints.

I checked and commit [3] is included in Zuul version used.
I made sure to use “connection” and “driver” kyewords in zuul configs as suggested.
I applied changes from https://review.openstack.org/#/c/300924/1 and I was able to verify, put +1 from my side.

I am able now to comment back to gerrit with 2nd gerrit account, which was the goal.
Still I have an issue (see below)

excerpt from WORKING zuul.conf
>>
[connection gerrit]
driver=gerrit
server=review.openstack.org
user=intel-nfv-ci
sshkey=/var/lib/zuul/ssh/id_rsa

[connection gerrit_networking]
driver=gerrit
server=review.openstack.org
user=intel-networking-ci
sshkey=/var/lib/zuul/ssh/id_rsa_intel-networking-ci at review.openstack.org<mailto:sshkey=/var/lib/zuul/ssh/id_rsa_intel-networking-ci at review.openstack.org>
>>

excerpt from WORKING layout.yaml
>>
    source: gerrit
    trigger:
      gerrit:
        - event: patchset-created
        - event: change-restored
        - event: comment-added
          comment: (?i)^(Patch Set [0-9]+:)?( [\w\\+-]*)*(\n\n)?\s*recheck intel\s*$
    success:
      gerrit_networking:
        verified: 1
>>

Issue I have is that despite layout is checked fine, when triggering job via comment in patchset, zuul fails on project config

2016-04-04 14:39:53,504 INFO zuul.Scheduler: Adding openstack-dev/ci-sandbox, <Change 0x7fcb20753a90 282323,1> to <Pipeline sandbox>
2016-04-04 14:39:53,504 DEBUG zuul.IndependentPipelineManager: Considering adding change <Change 0x7fcb20753a90 282323,1>
2016-04-04 14:39:53,505 ERROR zuul.Scheduler: Exception in run handler:
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/zuul/scheduler.py", line 962, in run
    self.process_event_queue()
  File "/usr/local/lib/python2.7/dist-packages/zuul/scheduler.py", line 1018, in process_event_queue
    pipeline.manager.addChange(change)
  File "/usr/local/lib/python2.7/dist-packages/zuul/scheduler.py", line 1366, in addChange
    with self.getChangeQueue(change, change_queue) as change_queue:
  File "/usr/local/lib/python2.7/dist-packages/zuul/scheduler.py", line 1889, in getChangeQueue
    if change.project not in self.pipeline.getProjects():
  File "/usr/local/lib/python2.7/dist-packages/zuul/model.py", line 111, in getProjects
    return sorted(self.job_trees.keys(), lambda a, b: cmp(a.name, b.name))
  File "/usr/local/lib/python2.7/dist-packages/zuul/model.py", line 111, in <lambda>
    return sorted(self.job_trees.keys(), lambda a, b: cmp(a.name, b.name))
AttributeError: 'NoneType' object has no attribute 'name'

Vaclav


From: Joshua Hesketh [mailto:joshua.hesketh at gmail.com]
Sent: Monday, April 4, 2016 05:41
To: Paul Belanger <pabelanger at redhat.com>
Cc: Hejral, VaclavX <vaclavx.hejral at intel.com>; Znoinski, Waldemar <waldemar.znoinski at intel.com>; openstack-infra at lists.openstack.org
Subject: Re: [OpenStack-Infra] multiple gerrit connections for ZUUL

Hello Vaclav,

Thanks for raising this, it looks like you've found a bug.

The layout validation test doesn't load the scheduler fully meaning that the scheduler is unaware of the connections and hence you see errors like the ones you've exampled.

If you start the zuul server without -t you should find that it'll validate and load. I suggest you do this in a non-production instance to double check, but I'd also be curious to see how it goes.

The second set of config you tried should be the correct one. ie:

[connection gerrit]
driver=gerrit

The important parts are the 'connection' keyword and the driver. The config section [gerrit] translates to the above for backwards compatibility.

I've got a patch to fix up the validation here: https://review.openstack.org/#/c/300924/

Cheers,
Josh

On Sat, Apr 2, 2016 at 12:02 AM, Paul Belanger <pabelanger at redhat.com<mailto:pabelanger at redhat.com>> wrote:
>
> Thanks,
> Vaclav
>
While I haven't tested it personally, we do have an example test fixture
documenting[1][2] what is needed for multiple gerrit servers.

My only comment would be to ensure you are using commit
352264b3c22b501ae53c1643e31df2ccdfc89388[3] or later, since that introduced the new
connection concept.

[1] https://git.openstack.org/cgit/openstack-infra/zuul/tree/tests/fixtures/layouts/good_connections1.conf
[2] https://git.openstack.org/cgit/openstack-infra/zuul/tree/tests/fixtures/layouts/good_connections1.yaml
[3] https://git.openstack.org/cgit/openstack-infra/zuul/commit/?id=352264b3c22b501ae53c1643e31df2ccdfc89388

_______________________________________________
OpenStack-Infra mailing list
OpenStack-Infra at lists.openstack.org<mailto:OpenStack-Infra at lists.openstack.org>
http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-infra

--------------------------------------------------------------
Intel Research and Development Ireland Limited
Registered in Ireland
Registered Office: Collinstown Industrial Park, Leixlip, County Kildare
Registered Number: 308263


This e-mail and any attachments may contain confidential material for the sole
use of the intended recipient(s). Any review or distribution by others is
strictly prohibited. If you are not the intended recipient, please contact the
sender and delete all copies.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20160404/c4173ff8/attachment-0001.html>