[OpenStack-Infra] Feature suggestion: Style check failures inlined as comments

Bruns, Curt E curt.e.bruns at intel.com
Tue Feb 17 23:34:08 UTC 2015


Problem Statement:
When a review fails pep8 style checks, a developer has to dig through the logs to figure out what failed.  e.g. In this review https://review.openstack.org/#/c/151737/, there is a pep8 failure. A developer has to click on the Jenkins gate-cinder-pep8 link, then the console.html.gz log, then search for errors.

As a developer, to help speed up development, it would be beneficial to have style check failures to be inserted as comments in code reviews.

Example:  Style Check failures showing up as inline comments:  http://review.whamcloud.com/#/c/13402/1/lustre/tests/parallel-scale-cifs.sh (HPDD Checkpatch auto-generates style check messages) I talked to the Intel folks and they used the Linux Checkpatch PERL script as the starting point :
http://lxr.free-electrons.com/source/scripts/checkpatch.pl

Would be great to have something similar in OpenStack.

Text above straight from:
https://etherpad.openstack.org/p/styleChecksInReviews

I’m willing to work on the feature if there are some suggestions on the best way to do it.

Thanks,
- Curt



More information about the OpenStack-Infra mailing list