Open Stack

On 01/19/2014 03:50 PM, Michael Still wrote:
> On Sun, Jan 19, 2014 at 11:01 PM, Monty Taylor <mordred at inaugust.com> wrote:
>> On 01/19/2014 05:38 AM, Sean Dague wrote:
> 
> [snip]
> 
>>> = Periodic recheck on old changes =
>>>
>>> I think Michael Still said he was working on this one. Certain projects,
>>> like Glance and Keystone, tend to approve things with really stale test
>>> results (> 1 month old). These fail, and then tumble. They are a be
>>> source of the wrecking balls.
>>
>> I believe he's got it working, actually. I think the real trick with this -
>> which I whole-heartedly approve of - is not making node starvation worse.
> 
> Yes, I wrote this on Friday. I wanted to write it as a zuul
> turbo-hipster plugin, but that wasn't possible because of the way
> results are returned in a comment by zuul, so its just a stand along
> python script instead. I've been running it on and off over the
> weekend, but only while I can watch and hand verify what it does to
> build some trust.
> 
> Node starvation is an issue, but we don't seem to be too bad at the
> moment in terms of check queue depth.
> 
>>> Tests results > 1 week are clearly irrelevant. For something like nova,
>>>>
>>>> 3 days can be problematic.
> 
> I am currently triggering on comments on reviews where the jenkins run
> is more than 7 days old. If you want me to tweak the age rule I am
> more than happy to.

Honestly, 7 days is good. I just saw a python-neutronclient change in
the gate that had tests last run in Oct. So lets go with 7 days for now
to get us under control.

Is this running now?

	-Sean

-- 
Sean Dague
http://dague.net

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 482 bytes
Desc: OpenPGP digital signature
URL: <http://lists.openstack.org/pipermail/openstack-infra/attachments/20140119/88edfe0f/attachment.pgp>