[OpenStack-Infra] BUG: [Cosmetic] Commiting a gerrit ChangeId before the commit hook was installed

Strainu strainu10 at gmail.com
Fri Jan 17 21:10:27 UTC 2014


2014/1/17 Jonathan Nieder <jrnieder at gmail.com>:
> Hi,
>
> Strainu wrote:
>
>> strainu at emily:~/core> git review -f
>> Creating a git remote called "gerrit" that maps to:
>>         ssh://strainu@gerrit.wikimedia.org:29418/pywikibot/core.git
>> Your change was committed before the commit hook was installed.
>> Amending the commit to add a gerrit change id.
>>
>> At this point I ended the transaction, as I was confused by the last
>> message: I was afraid the ChangeId would have changed, causing the
>> patch to be attached to another review.
>>
>> I think git should not show this message if the change description
>> already has a change id
>
> This message doesn't come from git.  It comes from the git-review
> tool (in git_review/cmd.py), so cc-ing the authors in case they
> have thoughts on that.

Thanks for clarifying that. I'll log a bug on launchpad then.

Strainu



More information about the OpenStack-Infra mailing list