<div dir="ltr">Hi,<div><br></div><div>I would like to comment before going to bed :-)</div><div><br></div><div><div>Japanese team discussed the same thing during Horizon translation review this weekend.</div><div>See my comment inline.</div><div><div class="gmail_extra"><br></div></div></div><div>2015-10-06 2:01 GMT+09:00 Andreas Jaeger <span dir="ltr"><<a href="mailto:aj@suse.com" target="_blank">aj@suse.com</a>></span>:<br></div><div><div class="gmail_extra"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class="">On 10/05/2015 06:54 PM, Ian Y. Choi wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Hello,<br>
<br>
Sorry if I am asking an already discussed issue.<br>
<br>
I am now reviewing horizon > stable-liberty > Documents (ko-KR)<br>
> openstack_dashboard/locale/django before our freezing deadline, as<br>
Daisy mentioned.<br>
<br>
But I have found that some Korean strings still have an error with the<br>
following message like:<br>
"Not enough lines in translation (expected 4, found 3)".<br>
</blockquote>
<br></span>
Akihiro, is this something you could look at in Horizon? Does horizon really need these as separate lines - or is that formatted automatically? Can we do something in horizon here to avoid these problems?<br></blockquote><div><br></div><div>I don't see any problems in this situation.</div><div>They are formatted automatically according to a regular HTML rendering rules.</div><div><br></div><div>What I can say is that this is a limitation of Django or underlying string extraction tool.<br></div><div>Django manage.py makemessage subcommand (which extracts translatable strings from sources codes and templates)</div><div>preserves newlines and spaces even though they have no meaning after rendering templates.</div><div>Hopefully Django tool deals with these strings into a single line (though it may be a hard thing) from the point of view of translators :-)</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<br>
Ian, I think this is fine, I don't see errors in the downloaded po files for Korean.<br>
<br>
The only error that msgfmt produces is if the original text has after the last line some white space - and you do not copy that.</blockquote><div><br></div><div><div>On the other hand, it is not productive to insert newlines just to avoid error warning from Zanata.<br class=""></div></div><div>Zanata prevents reviewers from approving translations when there is such error,</div><div>and we cannot complete reviews :-(</div><div><br></div><div><div><div># Japanese team insert meaningless newlines to avoid warnings for Liberty translations<br></div></div></div><div># but would not like to do that in the future.</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
The main reason I think is that in our previous translation platform<br>
Transifex,<br>
truncating the last empty line was recommended as far as I remember.<br>
(If not, Transifex generated an error.)<br>
<br>
My question is: should we fix those error translated strings with same<br>
number of lines and same spaces?<br>
I think it would be ignored because when I see Chinese translation,<br>
there were the same type of<br>
error message for almost translated strings.<br>
(Screenshot:<br>
<a href="https://www.dropbox.com/s/bvd098wsakpi192/Zanata_horizon_translation_example_in_zh-CN.png?dl=0" rel="noreferrer" target="_blank">https://www.dropbox.com/s/bvd098wsakpi192/Zanata_horizon_translation_example_in_zh-CN.png?dl=0</a><br>
)<br>
<br>
And if this error would be negligible to us, are there some ways not to<br>
see this type of errors?<br>
</blockquote>
<br></span>
Zanata allows to disable/enable some checks, but I think this error is nothing we can enable/disable. so, might be worth a feature request to the Zanata team.</blockquote><div><br></div><div><div>This kind of check is sometimes useful and sometimes not.</div><div>At the current configuration of Zanata, it seems a global configuration and translators cannot control the option.</div></div><div><br></div><div>Thanks,</div><div>Akihiro</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I would like to copy an example sentence string in Zanata from Korean<br>
for my better explanation.<br>
<br>
<in English>(Translated from)<br>
===<br>
First, select which type of job that<br>
you want to run. This choice will<br>
determine which<br>
other steps are required<br>
<br>
===<br>
<br>
<in Korean>(Translated to)<br>
===<br>
먼저, 실행하고자 하는 job 유형<br>
을 선택합니다. 이 선택을 통해 필요로 하는 다른<br>
과정들을 결정할 것입니다.<br>
===<br>
</blockquote>
<br>
<br></span>
Thanks, this is a good point to bring up!<span class=""><font color="#888888"><br>
<br>
Andreas<br>
-- <br>
Andreas Jaeger aj@{<a href="http://suse.com" rel="noreferrer" target="_blank">suse.com</a>,<a href="http://opensuse.org" rel="noreferrer" target="_blank">opensuse.org</a>} Twitter/Identica: jaegerandi<br>
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany<br>
GF: Felix Imendörffer, Jane Smithard, Graham Norton,<br>
HRB 21284 (AG Nürnberg)<br>
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126</font></span><div class=""><div class="h5"><br>
<br>
<br>
_______________________________________________<br>
Openstack-i18n mailing list<br>
<a href="mailto:Openstack-i18n@lists.openstack.org" target="_blank">Openstack-i18n@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-i18n</a><br>
</div></div></blockquote></div><br></div></div></div>