<div dir="ltr">Thanks for submitting the patches Roger. I have reviewed them and merged them. Although it meant that I had to rebase all the other patches up for review, I think the work is done at present :).<div><br></div><div>Regards,<br>Pranav</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Dec 2, 2015 at 7:51 PM, Roger Luethi <span dir="ltr"><<a href="mailto:rl@patchworkscience.org" target="_blank">rl@patchworkscience.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Tue, 01 Dec 2015 13:44:09 +0100, Christian Berendt wrote:<br>
</span><span class="">> Prior to adding the gate job the scripts in the training-labs<br>
> repository should be cleaned up, at least the errors should be<br>
> removed.<br>
><br>
> 306 bashate warning(s) found<br>
> 23 bashate error(s) found<br>
<br>
</span>I submitted three patches that (taken together) remove all errors and<br>
about a 100 warnings (while checking a few additional files).<br>
<br>
Fix bashate errors<br>
<a href="https://review.openstack.org/#/c/252541/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/252541/</a><br>
<br>
Simplify tox.ini bashate call<br>
<a href="https://review.openstack.org/#/c/252545/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/252545/</a><br>
<br>
Rename bash libraries for tox+bashate<br>
<a href="https://review.openstack.org/#/c/252546/" rel="noreferrer" target="_blank">https://review.openstack.org/#/c/252546/</a><br>
<span class="HOEnZb"><font color="#888888"><br>
Roger<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
OpenStack-docs mailing list<br>
<a href="mailto:OpenStack-docs@lists.openstack.org">OpenStack-docs@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
</div></div></blockquote></div><br></div>