<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Jul 21, 2015 at 2:53 PM, Steve Gordon <span dir="ltr"><<a href="mailto:sgordon@redhat.com" target="_blank">sgordon@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">----- Original Message -----<br>
> From: "Matt Kassawara" <<a href="mailto:mkassawara@gmail.com">mkassawara@gmail.com</a>><br>
> To: "Atsushi SAKAI" <<a href="mailto:sakaia@jp.fujitsu.com">sakaia@jp.fujitsu.com</a>><br>
><br>
> We should call these "weight" or "weights" to agree with every other<br>
> technical thing that uses this concept.<br>
<br>
</span>Aren't these configuration values based on the literal strings actually used in the code? E.g. (note that weighter appears to be a typo introduced in the docs, scheduler_default_weighters doesn't exist anywhere as a configuration key in the source code:<br>
<br>
sgordon@localhost:~/Source/cinder(master)> grep -r GoodnessWeighter *<br>
sgordon@localhost:~/Source/cinder(master)> grep -r GoodnessWeigher *<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:class GoodnessWeigherTestCase(test.TestCase):<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        super(GoodnessWeigherTestCase, self).setUp()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/tests/unit/scheduler/test_goodness_weigher.py:        weigher = goodness.GoodnessWeigher()<br>
cinder/scheduler/weights/goodness.py:class GoodnessWeigher(weights.BaseHostWeigher):<br>
setup.cfg:    GoodnessWeigher = cinder.scheduler.weights.goodness:GoodnessWeigher<br>
<br>
sgordon@localhost:~/Source/cinder(master)> grep -r "scheduler_default_weighters" * -r<br>
sgordon@localhost:~/Source/cinder(master)> grep -r "scheduler_default_weighers" * -r<br>
cinder/tests/unit/scheduler/test_scheduler.py:        # scheduler_default_filters and scheduler_default_weighers when<br>
cinder/tests/unit/scheduler/test_scheduler.py:                   scheduler_default_weighers=['CapacityWeigher'])<br>
cinder/tests/unit/scheduler/test_scheduler.py:        self.assertEqual(CONF.scheduler_default_weighers,<br>
cinder/tests/unit/scheduler/test_scheduler.py:                   scheduler_default_weighers=['CapacityWeigher'])<br>
cinder/tests/unit/scheduler/test_scheduler.py:        self.assertEqual(CONF.scheduler_default_weighers,<br>
cinder/scheduler/simple.py:  scheduler_default_weighers = 'ChanceWeigher'<br>
cinder/scheduler/simple.py:  scheduler_default_weighers = 'AllocatedCapacityWeigher'<br>
cinder/scheduler/host_manager.py:    cfg.ListOpt('scheduler_default_weighers',<br>
cinder/scheduler/host_manager.py:            CONF.set_override('scheduler_default_weighers',<br>
cinder/scheduler/host_manager.py:            CONF.set_override('scheduler_default_weighers',<br>
cinder/scheduler/host_manager.py:        it uses CONF.scheduler_default_weighers instead.<br>
cinder/scheduler/host_manager.py:            weight_cls_names = CONF.scheduler_default_weighers<br></blockquote><div><br></div><div>Oh, good. Thanks for looking it up Steve.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> On Tue, Jul 21, 2015 at 12:34 AM, Atsushi SAKAI <<a href="mailto:sakaia@jp.fujitsu.com">sakaia@jp.fujitsu.com</a>><br>
<span class="">> wrote:<br>
><br>
> > Hello<br>
> ><br>
> > I am looking around following document and find same two keywords are used<br>
> > on the document.<br>
> > Which word (weigher/weighter) is correct for this case?<br>
> ><br>
> > for example<br>
> >   GoodnessWeigher<br>
> >   VolumeNumberWeigher scheduler_default_weighters<br>
> ><br>
> > OpenStack Cloud Administrator Guide<br>
> > <a href="http://docs.openstack.org/draft/admin-guide-cloud-rst/" rel="noreferrer" target="_blank">http://docs.openstack.org/draft/admin-guide-cloud-rst/</a><br>
> ><br>
</span><span class="">> > Thanks<br>
> > Atsushi SAKAI<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > OpenStack-docs mailing list<br>
</span>> > <a href="mailto:OpenStack-docs@lists.openstack.org">OpenStack-docs@lists.openstack.org</a><br>
> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
<span class="im HOEnZb">> ><br>
><br>
> _______________________________________________<br>
> OpenStack-docs mailing list<br>
> <a href="mailto:OpenStack-docs@lists.openstack.org">OpenStack-docs@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
><br>
<br>
</span><span class="HOEnZb"><font color="#888888">--<br>
Steve Gordon, RHCE<br>
Sr. Technical Product Manager,<br>
Red Hat Enterprise Linux OpenStack Platform<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
OpenStack-docs mailing list<br>
<a href="mailto:OpenStack-docs@lists.openstack.org">OpenStack-docs@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature"><div dir="ltr"><div>Anne Gentle</div><div>Rackspace</div><div>Principal Engineer</div><div><a href="http://www.justwriteclick.com" target="_blank">www.justwriteclick.com</a></div></div></div>
</div></div>