<div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 23, 2015 at 10:18 AM, Nick Chase <span dir="ltr"><<a href="mailto:nchase@mirantis.com" target="_blank">nchase@mirantis.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><br>
Summarizing people's comments in one message, but if nothing else please skip to the bottom (it's important):<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Though I do understand push back to fix larger standards transgressions, for example some while ago I had a larger section I submitted with lots of examples where the spacing the the <screen> sections were all wrong so pointing out the error in the first one and saying "please check and fix the others" was completely appropriate. <br>
</blockquote>
<br></span>
For something like that, I completely agree; I mean, that's not what I consider a "minor cosmetic issue".<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
I tend to agree with Andreas that merging the change and oepning another bug for style/syntax is likely to accumulate debt, unless we get an influx of pre-summit people looking for cheap commits to get ATC badges. <br>
</blockquote>
<br></span>
I don't see this as a problem. As I said, we NEED a pool of these for first time contributors. If nothing else, these are the things that are reeeeeally easy for someone to knock off in an afternoon if they get out of control. (If necessary to move things forward, I will volunteer.)<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
For my part I tend to scan bugs when I have time (infrequently) for things that I have technical experience in actually doing, grammar isn't going to catch my interest. <br>
</blockquote>
<br></span>
No, but there are lots of writers who don't have the technical experience in a lot of what we do, but grammar they can handle.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
But we have to tell a contributor about our conventions to have high<br>
quality standards - and I agree that we should do this in a nice way.<br>
</blockquote></span>
Agreed. But we can do that with (as Diane suggested) a non-voting comment, which can ask them to open a second bug if they can't get to it to fix it. And even if they don't, if this is something that's truly a problem (rather than an irritation) somebody will open another bug.<span class=""><br>
<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
Which patch is triggering that that has so important information in it<br>
that it needs to go out half way?<br>
</blockquote>
<br></span>
This didn't come from a specific patch, but more of a general experience. (This was more of a "That's it, I've got to say something," kind of thing. :))<br>
<br>
I'm not looking to completely dismantle the way we ensure quality, and I don't think that this will do that. I'm simply looking to create a friendlier environment for contributors as we attempt to broaden our base.<br>
<br>
PLEASE READ THIS: The reality is that I have had multiple people tell me that they either dread submitting patches, or have stopped contributing altogether because it's such an unpleasant experience. We need to take this seriously and see what we can do to solve the problem.<br>
<br>
If we find that making a policy like this causes more harm than good, we can always change it back later.<span class=""><font color="#888888"><br>
<br></font></span></blockquote><div><br></div><div>Thanks for bringing it up. We do have guidelines here: <a href="https://wiki.openstack.org/wiki/Documentation/ReviewGuidelines">https://wiki.openstack.org/wiki/Documentation/ReviewGuidelines</a> so feel free to enhance those to help solve the problem.</div><div><br></div><div>All our reviews are a judgement call and I'd like us all (core, regulars, everyone) to be mindful and show good judgement.</div><div><br></div><div>Thanks,</div><div>Anne</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><span class=""><font color="#888888">
---- Nick</font></span><div class=""><div class="h5"><br>
<br>
<br>
<br>
______________________________<u></u>_________________<br>
OpenStack-docs mailing list<br>
<a href="mailto:OpenStack-docs@lists.openstack.org" target="_blank">OpenStack-docs@lists.<u></u>openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/<u></u>cgi-bin/mailman/listinfo/<u></u>openstack-docs</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature">Anne Gentle<br><a href="mailto:annegentle@justwriteclick.com" target="_blank">annegentle@justwriteclick.com</a></div>
</div></div>