<div dir="ltr"><br><div class="gmail_extra"><br><br><div class="gmail_quote">On Sat, Mar 15, 2014 at 5:04 PM, David O'Brien <span dir="ltr"><<a href="mailto:dob12460@gmail.com" target="_blank">dob12460@gmail.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex"><div dir="ltr"><div><div>How strict is it? Does it need to be one or the other?<br>
<br></div>I'm thinking about if somebody happened to write <option>= True and experienced a failure because of one missing space. Might be hard to troubleshoot. Can you support both, and recommend using spaces for readability?<br>

<br></div>Just a thought.<br><br></div><div class="gmail_extra"><div><div class="h5"><br><br><div class="gmail_quote">On Wed, Mar 12, 2014 at 5:34 AM, Phil Hopkins <span dir="ltr"><<a href="mailto:phil.hopkins@rackspace.com" target="_blank">phil.hopkins@rackspace.com</a>></span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">Gauvain,<br>
<br>
You are correct, that was what I was thinking and I put it in the boolean section. Thanks forcorrecting<br>
this.<br>
<br>
Phil Hopkins RHCA CMDBA<br>
Openstack Instructor<br>
Rackspace Hostingtm<br>
(210) 312-3584<br>
<br>
________________________________________<br>
From: Gauvain Pocentek [<a href="mailto:gauvain.pocentek@objectif-libre.com" target="_blank">gauvain.pocentek@objectif-libre.com</a>]<br>
Sent: Tuesday, March 11, 2014 2:26 PM<br>
To: Phil Hopkins<br>
Cc: openstack-docs<br>
Subject: Re: [Openstack-docs] Boolean configuration options<br>
<div><div><br>
Le 2014-03-11 19:44, phil hopkins a écrit :<br>
> I would like to post a change to the Boolean configuration options. I<br>
> believe that for alll of the configuration files we should use the<br>
> form:<br>
><br>
> force_dhcp_release = True<br>
><br>
> as opposed to:<br>
><br>
> force_dhcp_release=True<br>
><br>
> using a space on either side of the equals sign. This makes it easier<br>
> to separate the configuration item and the option. I believe it is<br>
> easier to read.<br>
><br>
> Any comments?<br>
<br>
+1<br>
<br>
But why limit this to boolean options? We could use this convention for<br>
all the options.<br></div></div></blockquote></div></div></div></div></blockquote><div>I'm not familiar with the config files, but one concern to me from the experience with bash script is:</div>variable declaration in bash script can not have space (or space will change the meaning of the command)</div>
<div class="gmail_quote"><br></div><div class="gmail_quote"><p style="margin:0px 0px 1em;padding:0px;border:0px;font-size:14px;vertical-align:baseline;clear:both;color:rgb(0,0,0);font-family:Arial,'Liberation Sans','DejaVu Sans',sans-serif;line-height:17.804800033569336px">
When you write:</p><pre class="" style="margin-top:0px;margin-bottom:10px;padding:5px;border:0px;font-size:14px;vertical-align:baseline;background-color:rgb(238,238,238);font-family:Consolas,Menlo,Monaco,'Lucida Console','Liberation Mono','DejaVu Sans Mono','Bitstream Vera Sans Mono','Courier New',monospace,serif;overflow:auto;width:auto;max-height:600px;word-wrap:normal;color:rgb(0,0,0);line-height:17.804800033569336px">
<code style="margin:0px;padding:0px;border:0px;vertical-align:baseline;font-family:Consolas,Menlo,Monaco,'Lucida Console','Liberation Mono','DejaVu Sans Mono','Bitstream Vera Sans Mono','Courier New',monospace,serif;white-space:inherit"><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">STR </span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">=</span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent"> </span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent;color:rgb(128,0,0)">"foo"</span></code></pre>
<p style="margin:0px 0px 1em;padding:0px;border:0px;font-size:14px;vertical-align:baseline;clear:both;color:rgb(0,0,0);font-family:Arial,'Liberation Sans','DejaVu Sans',sans-serif;line-height:17.804800033569336px">
bash tries to run a command named STR with 2 arguments (the strings '=' and 'foo')</p><p style="margin:0px 0px 1em;padding:0px;border:0px;font-size:14px;vertical-align:baseline;clear:both;color:rgb(0,0,0);font-family:Arial,'Liberation Sans','DejaVu Sans',sans-serif;line-height:17.804800033569336px">
When you write:</p><pre class="" style="margin-top:0px;margin-bottom:10px;padding:5px;border:0px;font-size:14px;vertical-align:baseline;background-color:rgb(238,238,238);font-family:Consolas,Menlo,Monaco,'Lucida Console','Liberation Mono','DejaVu Sans Mono','Bitstream Vera Sans Mono','Courier New',monospace,serif;overflow:auto;width:auto;max-height:600px;word-wrap:normal;color:rgb(0,0,0);line-height:17.804800033569336px">
<code style="margin:0px;padding:0px;border:0px;vertical-align:baseline;font-family:Consolas,Menlo,Monaco,'Lucida Console','Liberation Mono','DejaVu Sans Mono','Bitstream Vera Sans Mono','Courier New',monospace,serif;white-space:inherit"><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">STR </span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">=</span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">foo</span></code></pre>
<p style="margin:0px 0px 1em;padding:0px;border:0px;font-size:14px;vertical-align:baseline;clear:both;color:rgb(0,0,0);font-family:Arial,'Liberation Sans','DejaVu Sans',sans-serif;line-height:17.804800033569336px">
bash tries to run a command named STR with 1 argument (the string '=foo')</p><p style="margin:0px 0px 1em;padding:0px;border:0px;font-size:14px;vertical-align:baseline;clear:both;color:rgb(0,0,0);font-family:Arial,'Liberation Sans','DejaVu Sans',sans-serif;line-height:17.804800033569336px">
When you write:</p><pre class="" style="margin-top:0px;margin-bottom:10px;padding:5px;border:0px;font-size:14px;vertical-align:baseline;background-color:rgb(238,238,238);font-family:Consolas,Menlo,Monaco,'Lucida Console','Liberation Mono','DejaVu Sans Mono','Bitstream Vera Sans Mono','Courier New',monospace,serif;overflow:auto;width:auto;max-height:600px;word-wrap:normal;color:rgb(0,0,0);line-height:17.804800033569336px">
<code style="margin:0px;padding:0px;border:0px;vertical-align:baseline;font-family:Consolas,Menlo,Monaco,'Lucida Console','Liberation Mono','DejaVu Sans Mono','Bitstream Vera Sans Mono','Courier New',monospace,serif;white-space:inherit"><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">STR</span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent">=</span><span class="" style="margin:0px;padding:0px;border:0px;vertical-align:baseline;background-color:transparent"> foo</span></code></pre>
<p style="margin:0px 0px 1em;padding:0px;border:0px;font-size:14px;vertical-align:baseline;clear:both;color:rgb(0,0,0);font-family:Arial,'Liberation Sans','DejaVu Sans',sans-serif;line-height:17.804800033569336px">
bash tries to run the command foo with STR set to the empty string in its environment.</p><div><a href="http://stackoverflow.com/questions/2268104/basic-bash-script-variable-declaration-command-not-found">http://stackoverflow.com/questions/2268104/basic-bash-script-variable-declaration-command-not-found</a>  </div>
<div>I probably prefer the way as it is now: <span style="color:rgb(80,0,80)">force_dhcp_release=True</span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div class="gmail_extra"><div><div class="h5"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><div>
<br>
Gauvain Pocentek<br>
<br>
Objectif Libre - Infrastructure et Formations Linux<br>
<a href="http://www.objectif-libre.com" target="_blank">http://www.objectif-libre.com</a><br>
<br>
<br>
_______________________________________________<br>
Openstack-docs mailing list<br>
<a href="mailto:Openstack-docs@lists.openstack.org" target="_blank">Openstack-docs@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
</div></div></blockquote></div><br><br clear="all"><br></div></div><span class=""><font color="#888888">-- <br>/David<br>
</font></span></div>
<br>_______________________________________________<br>
Openstack-docs mailing list<br>
<a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
<br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div dir="ltr">Qian Zhang 张倩<div>M: +61 401 909 897<br>T: +61 262 167 148</div><div>PhD Candidate, Cloud Computing<br>S326 Computer and Information Technology Building (Building 108)<br>
ANU ID: U5214628<span style="background-color:rgb(255,255,255)"><br></span><br></div></div>
</div></div>