<p dir="ltr">I talked to Matt this morning and am going to follow up putting something together based on what they have. </p>
<div class="gmail_quote">On Dec 15, 2013 10:08 AM, "Diane Fleming" <<a href="mailto:diane.fleming@rackspace.com">diane.fleming@rackspace.com</a>> wrote:<br type="attribution"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
This is great stuff. Guidelines for how to provide review comments, and some protocols for when and how to patch someone else's work would be awesome. Let me know how I can help.<br>
<br>
Sent from my iPhone<br>
<br>
> On Dec 14, 2013, at 3:44 PM, "Nicholas Chase" <<a href="mailto:nchase@mirantis.com">nchase@mirantis.com</a>> wrote:<br>
><br>
> I like the examples as well. I think it DOES go under the "Documentation" umbrella -- the way that anything that explains how to develop or use OpenStack effectively does. I think that the CodeReviewGuidelines are a subset of this; the two should crosslink, so that you can go from one to the other easily.<br>
><br>
> I also think that this content should be as obvious as "How to contribute"; it's really pretty important.<br>
><br>
> ---- Nick<br>
><br>
>> On 12/13/2013 6:36 PM, Anne Gentle wrote:<br>
>> Hi all,<br>
>> I liked Matthew's examples of how to nicely suggest improvements to<br>
>> commit messages, review comments, and so on. Something about a<br>
>> monocle-wearing English gentleman's polite speech leads me to believe<br>
>> that our community members would appreciate some guidelines and<br>
>> training, but I don't know how others feel about this under a<br>
>> "Documentation" umbrella. Perhaps it belongs with the<br>
>> CodeReviewGuidelines? More input and discussion -- with the idea being,<br>
>> how can we help improve communication around the code and docs?<br>
>> Thanks,<br>
>> Anne<br>
>><br>
>><br>
>> On Thu, Dec 12, 2013 at 2:38 AM, Matthew Mosesohn<br>
>> <<a href="mailto:mmosesohn@mirantis.com">mmosesohn@mirantis.com</a> <mailto:<a href="mailto:mmosesohn@mirantis.com">mmosesohn@mirantis.com</a>>> wrote:<br>
>><br>
>> Hi Stackers,<br>
>><br>
>> After some discussion about the Code Review Guidelines<br>
>> (<a href="https://wiki.openstack.org/wiki/CodeReviewGuidelines" target="_blank">https://wiki.openstack.org/wiki/CodeReviewGuidelines</a>), it's come to<br>
>> my attention that there is plenty of advice that could be shared with<br>
>> the rest of the community about how to participate effectively, yet<br>
>> respectfully, in various forms of communication. The scope of<br>
>> communication I want to cover includes messages on IRC, mailing lists,<br>
>> code review, and commit messages. It's quite obvious for most of you<br>
>> that kindness and respect for your fellow developer helps reduce<br>
>> friction that may arise when trying to contribute to OpenStack or get<br>
>> help.<br>
>><br>
>> The intended audience for this discussion is not our core contributors<br>
>> who speak English as a native language, but instead for those who are<br>
>> interested in participating, but need to improve their writing skills.<br>
>> Frankly speaking, in some languages, direct speech can seem harsh when<br>
>> written literally in English.<br>
>><br>
>> After speaking with Anne Gentle, she suggested creating a<br>
>> communcations guideline page as a child page under<br>
>> <a href="https://wiki.openstack.org/wiki/Documentation/Conventions" target="_blank">https://wiki.openstack.org/wiki/Documentation/Conventions</a> with a<br>
>> similar format, showing correct and incorrect models of communication.<br>
>><br>
>> The intent of starting this thread is to field some suggestions or<br>
>> possibly point out some examples of items that should be included in<br>
>> this document. I'm not asking for serious investment from the Docs<br>
>> team, but if you have ideas, please feel free to share them. Thank you<br>
>> for your time.<br>
>><br>
>> Best Regards,<br>
>> Matthew Mosesohn<br>
>><br>
>> _______________________________________________<br>
>> Openstack-docs mailing list<br>
>> <a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
>> <mailto:<a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a>><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
>><br>
>><br>
>><br>
>><br>
>> _______________________________________________<br>
>> Openstack-docs mailing list<br>
>> <a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
><br>
> _______________________________________________<br>
> Openstack-docs mailing list<br>
> <a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
</blockquote></div>