<div dir="ltr">If other core teams are reviewing in this way I'm fine with it too.<div><br></div><div>Anne</div></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 4, 2013 at 6:50 PM, Jeremy Stanley <span dir="ltr"><<a href="mailto:fungi@yuggoth.org" target="_blank">fungi@yuggoth.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im">On 2013-12-04 21:05:12 +0100 (+0100), Andreas Jaeger wrote:<br>
> During the review of creating openstack-doc-tools, I was asked whether<br>
> we want to have the ability to allow core-reviewers to set<br>
> Workinprogress on a patch.<br>
</div>[...]<br>
<br>
Just a tip: if your core review team is struggling with an<br>
overwhelming volume of outstanding changes, having the ability to<br>
acknowledge that a contributor will definitely need to do more work<br>
on one by setting it to WIP rather than merely expressing an opinion<br>
on its readiness can be a great convenience to fellow reviewers. It<br>
allows you to politely send the message that it needs additional<br>
work while simultaneously removing it from the list of ready changes<br>
until that happens. (Of course, you should still explain to the<br>
contributor what needs doing; that goes without saying.)<br>
<span class="HOEnZb"><font color="#888888">--<br>
Jeremy Stanley<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
_______________________________________________<br>
Openstack-docs mailing list<br>
<a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br>Anne Gentle<br><a href="mailto:annegentle@justwriteclick.com" target="_blank">annegentle@justwriteclick.com</a>
</div>