<br><br><div class="gmail_quote">On Thu, Jul 18, 2013 at 7:19 PM, Denis Bradford <span dir="ltr"><<a href="mailto:denisbatgm@gmail.com" target="_blank">denisbatgm@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
fwiw, here's the link that fails, in computescheduler.xml:<br>
<br>
If per-aggregate value is not found, it falls back to the <link<br>
linkend="compute-scheduler-config-ref">default setting</link>.<br>
<br>
The link target is in ch_computescheduler.xml, a chapter in the<br>
openstack-config manual<br></blockquote><div><br>Yes, Denis, it actually links to a Configuration Table. <br><br>I erroneously deleted the section when I updated the Weights section (the validation failed, as you saw, but the build was ok). I patched it a couple of hours ago and Lorin reviewed it (thanks!). So you can update your local repository and test it again.<br>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
And I thought I was doing something trivial for my first checkin :-P<br></blockquote><div><br>I'm yet to find something trivial in docs ;). <br><br>Thanks for the catch, and sorry for the mess!<br><br>Laura<br><br>PS: Since I had backported the offending patch to grizzly, I tried to validate it too. A validation error does appear, but it's related to the host_aggregates.xml (not the ch_computescheduler.xml), so I'll try to propose a patch for that one too.<br>
<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Thu, Jul 18, 2013 at 4:22 PM, David Cramer<br>
<<a href="mailto:david.cramer@rackspace.com">david.cramer@rackspace.com</a>> wrote:<br>
> On 07/18/2013 03:08 PM, Lorin Hochstein wrote:<br>
>> David:<br>
>><br>
>> Yes, the validation script are only looking at individual files right<br>
>> now, which is why they don't catch missing cross-references.<br>
>><br>
>> I agree that maven would be better for gating. But maven isn't currently<br>
>> gating, is it?<br>
><br>
> Now that I think of it more, Maven is the only thing that can really<br>
> validate this because you might have a file that's valid on the file<br>
> system but invalid after profiling:<br>
><br>
> Say you have <section xml:id="foo" condition="rhel">...</section> and<br>
> elsewhere <xref linkend="foo"/>. When you build validate with your<br>
> script, all is well because the IDREF linkend="foo" matches<br>
> xml:id="foo", but if you build with profileCondition=ubuntu, that<br>
> section is removed and you have a broken link.<br>
><br>
> The build will blow up if there's an IDREF without a matching ID in the<br>
> document UNLESS failOnValidationError=no.<br>
><br>
> As of 1.6.x, Maven validates the doc twice: first after resolving<br>
> xincludes it validates without checking IDREFs, then again towards the<br>
> end after all profiling etc, it checks IDREFs as well. This is to catch<br>
> the situation where the doc was valid but was made invalid by filtering<br>
> out content. In 1.8.0, I give you a more helpful error message that<br>
> suggests opening an intermediate file in the target dir and validating<br>
> it so you can see the actual error (line numbers are meaningless since<br>
> the original source file has been manipulated by resolving xincludes etc).<br>
><br>
> Does that make sense?<br>
><br>
> If leaving the failOnValidationError=no door available is a bad thing, I<br>
> could easily make it so failOnValidationError is ignored if<br>
> branding=openstack. Or perhaps Jenkins could pass in<br>
> failOnValidationError=yes, which would override what's in the pom (or<br>
> some other trick to make sure Jenkins never builds something where<br>
> validation doesn't kill the build).<br>
><br>
> David<br>
><br>
> _______________________________________________<br>
> Openstack-docs mailing list<br>
> <a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
<br>
_______________________________________________<br>
Openstack-docs mailing list<br>
<a href="mailto:Openstack-docs@lists.openstack.org">Openstack-docs@lists.openstack.org</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-docs</a><br>
</div></div></blockquote></div><br>