[Openstack-docs] Patch for automated Debian installations

Thomas Goirand zigo at debian.org
Tue Jun 3 08:22:38 UTC 2014


On 06/03/2014 02:47 AM, Andreas Jaeger wrote:
> I've took the time to review the distribution specific parts in a bit
> more detail.
> 
> Looking at the Image Service example, it's basically really only this
> section which is completely different:
> 
> On 06/02/2014 05:46 PM, Thomas Goirand wrote:
>> [...]
>> Another example. See this (from the Ubuntu guide):
>>
>> http://docs.openstack.org/icehouse/install-guide/install/apt/content/glance-install.html
>>
>> and now see this (from the Debian guide):
>>
>> http://docs.openstack.org/icehouse/install-guide/install/apt-debian/content/glance-install.html
> 
> And this is different from all other distributions, Debian is the odd
> one out.

Yeah!

> Looking at the description for me it's not so much that Debian
> is using a different tool - it's a complete different way of describing
> it. While for the non-Debian distros, we explicitly document which
> variables to set, I see here "Respond to prompts" without any guidance
> on what to answer - and that means to me what you document is a
> different kind of guide then what we describe. Looking at the
> screenshot, the non-Debian guides would write something like:
> "Respond the pipeline question with 'keystone'".
> 
> And that's for me the question - are we working on the same kind of guide?

I agree with this. I believe there should be more explanation of what
directive is edited by responding to the prompts. If you let me, I'll
add that in the Debian doc.

> Thomas, btw. I think part of this is also triggered by comments like you
> do in https://review.openstack.org/#/c/97156/. I do have added you as
> reviewer in the past to several patches and sometimes didn't get a
> review in a timely manner. We work on a best effort base and many of us
> on a volunteer base - like you - and while I understand your some of
> your frustration, such comments might lead some to not review your
> patches at all,
> 
> Andreas

Andreas, I'm sorry if you feel bad about the patch comment. I thought
what happened was a mistake, and lots of what I did for Havana went
away. It as a bit frustrating for me, which lead to that text. Though:

"It'd be nice if I didn't have to do such work again in the future (eg:
if reviewers took care of not having these get in again)."

is IMO written in a nice way. It's "it'd be nice if", not "WTF did the
reviewer"... So please don't take it as badness, it's just a bit of
frustration on my side.

Also, you must know that I appreciated a lot all the time you spent
reviewing my patches. Which is why I was so happy to see you in Atlanta.
I felt regret I didn't spend enough time with you and had no opportunity
to drink a beer with you to say thank you. I hope we'll met again in
Paris, and this time, I'll make sure to spend enough time with the doc
team! :)

Last thing: I think I did a few review. If I missed some, then please
forgive me. Please add me again on reviews, and I'll do my best to find
the time to do the work.

Cheers,

Thomas




More information about the Openstack-docs mailing list