Open Stack

----- Original Message -----
> From: "Andreas Jaeger" <jaegerandi at gmail.com>
> To: sgordon at redhat.com
> Sent: Thursday, September 12, 2013 2:59:52 PM
> Subject: Re: Change in openstack/openstack-manuals[master]: Fixed repeated "and" in IBM Storwize Driver content.
> 
> See commit 31743bb1d5c90723624e8fb4dcc3cf0b7618a2e7 - I run a check some
> days ago and picked up duplicates. This needs to be done regularly ;(
> 
> Thanks,
> Andreas

Right, at the bootcamp earlier in the week those of us present talked about possibly expanding the validation checks and splitting out into multiple jobs (some voting, some non-voting). A repeated words check definitely looks like it's one of the jobs we could/should consider :).

My check is pretty basic (dumb) and as a result picks up some erroneous results though so couldn't be voting, e.g.:

$ for file in `find . -name *.xml`; do grep -Pro '\s+(\w+)\s+\1\s+' $file; done
 nova nova 
 nova nova 
                    and and 
 root root 
 ayoung ayoung 
 ayoung ayoung 
 ayoung ayoung 
 80 80 
 80 80 
 22 22 
 22 22 
  ____               ____  
 ____ ____ 
 22 22 
 22 22 
 53 53 
 22 22 
 22 22 
 22 22 

What does your check look like? Either way if we could add one of these as a non-voting validation check that would be a start (I am working back through the jenkins-job-builder tutorial working out how to go about doing this :)).

Steve

> On Thu, Sep 12, 2013 at 8:57 PM, Stephen Gordon (Code Review) <
> review at openstack.org> wrote:
> 
> > Stephen Gordon has posted comments on this change.
> >
> > Change subject: Fixed repeated "and" in IBM Storwize Driver content.
> > ......................................................................
> >
> >
> > Patch Set 1:
> >
> > I was actually surprised/impressed the check I ran didn't pick up more
> > (that or my check is wrong ;)).
> >
> > --
> > To view, visit https://review.openstack.org/46338
> > To unsubscribe, visit https://review.openstack.org/settings
> >
> > Gerrit-MessageType: comment
> > Gerrit-Change-Id: Ib3e518bcf8ccfcd6fa91370111a58a3a8c30ea92
> > Gerrit-PatchSet: 1
> > Gerrit-Project: openstack/openstack-manuals
> > Gerrit-Branch: master
> > Gerrit-Owner: Stephen Gordon <sgordon at redhat.com>
> > Gerrit-Reviewer: Andreas Jaeger <jaegerandi at gmail.com>
> > Gerrit-Reviewer: Jenkins
> >
> 
> 
> 
> --
> Andreas Jaeger
>  jaegerandi at gmail.com
>   http://andreasjaeger.blogspot.com
> 

-- 
Steve Gordon, RHCE
Documentation Lead, Red Hat OpenStack
Engineering Content Services
Red Hat Canada (Toronto, Ontario)