<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class=""><div class="">Keep in mind <font color="#ff1f00" class="">pre-commit tool != git-hooks</font>, is like confusing JavaScript with Java ;)</div><div class=""><br class=""></div><div class="">By default pre-commit does not install any hooks. Yes, you can install them, but in 9/10 cases I don't, I only have an alias pc="pre-commit run -a" which I run before each git-review. In fact I was considering adding an optional feature to git-review to auto run this when the repository has a .pre-commit-config.yml file.</div><div class=""><br class=""></div>I am glad someone else opened the pre-commit subject before me. While it comes with its own challenges (git cloning), pre-commit resolves the problem of having predictable linter results by pinning them. Also it enables vey easy bumping of all of them.<div class=""><br class=""></div><div class="">AFAIK, over the last year I removed hacking from several projects and replaced it with pre-commit and I am much happier.</div><div class=""><br class=""></div><div class="">Not sure if others know but both bashate and doc8 can be used from pre-commit too.</div><div class=""><br class=""></div><div class="">Extra bonus: we can avoid the case where we end-up having tons of jobs performing linting or style checks. <div class=""><div><br class=""></div><div><blockquote type="cite" class=""><div class="">On 22 Nov 2019, at 13:11, Sean Mooney <<a href="mailto:smooney@redhat.com" class="">smooney@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div class="">On Thu, 2019-11-21 at 15:32 -0800, Dan Smith wrote:<br class=""><blockquote type="cite" class=""><blockquote type="cite" class="">nova only has a couple but it might be intersting to convert those to precommit scripts.<br class="">looking through them some of them do seam useful although other are just python 2 vs python 3<br class="">guidline that i hope will be less relevant now.<br class=""></blockquote><br class="">I would so very much love if we did NOT do that. Precommit hooks are<br class="">super annoying for writing up quick PoCs and DNM patches, which we do a<br class="">lot.<br class=""></blockquote>ya true although i was referign to the precommit framework which we previously disucssed and said<br class="">shoudl be optional to install. do you think we should keep/maintain hacking in nova and or port these<br class="">to something else if not? anyway it was just a thought i dont want it to be mandaroy on every commit<br class="">for the poc hacking reason either but it might be a way to keep the checks without having to contiue to<br class="">maintain hacking.<br class=""><blockquote type="cite" class=""><br class="">--Dan<br class=""><br class=""></blockquote><br class=""><br class=""></div></div></blockquote></div><br class=""></div></div></body></html>