<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body dir="auto"><div dir="ltr"></div><div dir="ltr">I agree with your concerns about code churn. I think it’s still useful to run a small experiment to demonstrate how we might actually benefit from them though, which applying them to one library would let us do. </div><div dir="ltr"><br>On Jan 26, 2019, at 1:18 PM, Morgan Fainberg <<a href="mailto:morgan.fainberg@gmail.com">morgan.fainberg@gmail.com</a>> wrote:<br><br></div><blockquote type="cite"><div dir="ltr"><div dir="auto">Honestly, I would wait for this for the U release. We can then go to the annotation style and if needed update docstrings at the same time. My concern with pushing this now is a high churn of code that should be duplicated once we drop PY2 support.<div dir="auto"><br></div><div dir="auto">Other than my above concerns the type checking in mypy would be great to have. </div><div dir="auto"><br></div><div dir="auto">--Morgan</div></div><br><div class="gmail_quote"><div dir="ltr">On Sat, Jan 26, 2019, 09:14 Sergey Vilgelm <<a href="mailto:sergey@vilgelm.info">sergey@vilgelm.info</a> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div name="messageBodySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif">Cyril,
<div><br></div>
<div>We have lots of doc strings in rst format and many of them already have the `@param` and `@type` tags. Does the mypy support this format or we should to rewrite doc string and add the `type:` tags just for mypy?</div>
</div>
<div name="messageSignatureSection"><br>
<div class="m_7337578728341483557matchFont">
<div style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif">--</div>
Sergey Vilgelm
<div style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif">
<div style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif"><a href="https://www.vilgelm.info" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif" target="_blank" rel="noreferrer">https://www.vilgelm.info</a></div>
</div>
</div>
</div>
<div name="messageReplySection" style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif">On Jan 26, 2019, 9:07 AM -0600, Cyril Roelandt <<a href="mailto:cyril@redhat.com" target="_blank" rel="noreferrer">cyril@redhat.com</a>>, wrote:<br>
<blockquote type="cite" style="margin:5px 5px;padding-left:10px;border-left:thin solid #1abc9c">Hello Doug,<br>
<br>
On 01/26/19 09:02, Doug Hellmann wrote:<br>
<blockquote type="cite" style="margin:5px 5px;padding-left:10px;border-left:thin solid #e67e22">We're still required to support python 2 through the beginning of the U<br>
cycle [5]. Is it possible to apply the type hints in a way that allows<br>
us to maintain that support?<br>
<br>
[5] <a href="https://governance.openstack.org/tc/resolutions/20180529-python2-deprecation-timeline.html" target="_blank" rel="noreferrer">https://governance.openstack.org/tc/resolutions/20180529-python2-deprecation-timeline.html</a><br></blockquote>
<br>
There are two ways to apply type hints:<br>
1) Use a new syntax that only works with Python 3<br>
2) Use comments (see my github branch, where comments starting with<br>
"type:" can be found)<br>
<br>
I used the second approach in order to not break Python 2 compatibility.<br>
<br>
<br>
Regards,<br>
Cyril<br>
<br></blockquote>
</div>
</div>
</blockquote></div>
</div></blockquote></body></html>