[TripleO][Validations] Tag convention
mnaser at vexxhost.com
Tue May 7 16:24:42 UTC 2019
On Tue, May 7, 2019 at 12:12 PM Emilien Macchi <emilien at redhat.com> wrote:
> On Tue, May 7, 2019 at 4:44 PM Cédric Jeanneret <cjeanner at redhat.com> wrote:
>> Dear all,
>> We're currently working hard in order to provide a nice way to run
>> validations within a deploy (aka in-flight validations).
>> We can already call validations provided by the tripleo-validations
>> package, it's working just fine.
>> Now comes the question: "how can we disable the validations?". In order
>> to do that, we propose to use a standard tag in the ansible
>> roles/playbooks, and to add a "--skip-tags <tag>" when we disable the
>> validations via the CLI or configuration.
>> After a quick check in the tripleoclient code, there apparently is a tag
>> named "validation", that can already be skipped from within the client.
>> So, our questions:
>> - would the reuse of "validation" be OK?
>> - if not, what tag would be best in order to avoid confusion?
>> We also have the idea to allow to disable validations per service. For
>> this, we propose to introduce the following tag:
>> - validation-<service>, like "validation-nova", "validation-neutron" and
>> so on
>> What do you think about those two additions?
> Such as variables, I think we should prefix all our variables and tags with tripleo_ or something, to differentiate them from any other playbooks our operators could run.
> I would rather use "tripleo_validations" and "tripleo_validation_nova" maybe.
Just chiming in here.. the pattern we like in OSA is using dashes for
tags, I think having something like 'tripleo-validations' and
> Emilien Macchi
Mohammed Naser — vexxhost
D. 800-910-1726 ext. 200
E. mnaser at vexxhost.com
More information about the openstack-discuss