[openstack-helm] would like to discuss review turnaround time

Jaesuk Ahn bluejay.ahn at gmail.com
Wed Jan 30 04:15:13 UTC 2019

Dear all,

There has been several patch sets getting sparse reviews.
Since some of authors wrote these patch sets are difficult to join IRC
meeting due to time and language constraints, I would like to pass some of
their voice, and get more detail feedback from core reviewers and other
devs via ML.

I fully understand core reviewers are quite busy and believe they are doing
their best efforts. period!

However, I sometimes feel that turnaround time for some of patch sets are
really long. I would like to hear opinion from others and suggestions on
how to improve this. It can be either/both something each patch set owner
need to do more, or/and it could be something we as a openstack-helm
project can improve. For instance, it could be influenced by time
differences, lack of irc presence, or anything else. etc. I really would
like to find out there are anything we can improve together.

I would like to get any kind of advise on the following.
- sometimes, it is really difficult to get core reviewers' comments or
reviews. I routinely put the list of patch sets on irc meeting agenda,
however, there still be a long turnaround time between comments. As a
result, it usually takes a long time to process a patch set, does sometimes
cause rebase as well.
- Having said that, I would like to have any advise on what we need to do
more, for instance, do we need to be in irc directly asking each patch set
to core reviewers? do we need to put core reviewers' name when we push
patch set? etc.
- Some of patch sets are being reviewed and merged quickly, and some of
patch sets are not. I would like to know what makes this difference so that
I can tell my developers how to do better job writing and communicating
patch sets.

There are just some example patch sets currently under review stage.

1. https://review.openstack.org/#/c/603971/ >> this ps has been discussed
for its contents and scope. Cloud you please add if there is anything else
we need to do other than wrapping some of commit message?

2. https://review.openstack.org/#/c/633456/ >> this is simple fix. how can
we make core reviewer notice this patch set so that they can quickly view?

3. https://review.openstack.org/#/c/625803/ >> we have been getting
feedbacks and questions on this patch set, that has been good. but
round-trip time for the recent comments takes a week or more. because of
that delay (?), the owner of this patch set needed to rebase this one
often. Will this kind of case be improved if author engages more on irc
channel or via mailing list to get feedback rather than relying on gerrit

Frankly speaking, I don't know if this is a real issue or just way it is. I
just want to pass some of voice from our developers, and really would like
to hear what others think and find a better way to communicate.

Thanks you.

*Jaesuk Ahn*, Ph.D.
Software Labs, SK Telecom
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstack.org/pipermail/openstack-discuss/attachments/20190130/7357a123/attachment.html>

More information about the openstack-discuss mailing list