[dev] Upcoming git-review changes

Stephen Finucane sfinucan at redhat.com
Fri Jan 25 16:55:14 UTC 2019


Happy Friday,

Just a quick heads up that the upcoming release of git-review, likely
2.0, removes a feature. Currently, git-review will detect the presence
of "bug", "lp", "blueprint" or "bp" in commit messages and, if found,
set the Gerrit topic for that submitted review to something based on
the blueprint/bug.

As noted in the commit that removed this [1], this hadn't been updated
to support StoryBoard and there was no desire to do so given the
OpenStack-specific nature of this feature along with the fact that it
often did the wrong thing.

We (being the people who authored and reviewed the patch) think this is
definitely a good thing to do, but if anyone has genuine concerns about
the removal of this functionality, be sure to raise them here or on
#openstack-infra before we push that release out next week.

Cheers,
Stephen

[1] https://github.com/openstack-infra/git-review/commit/03768832c4




More information about the openstack-discuss mailing list