On 8/21/19 3:44 PM, Eric Fried wrote: >>>> NOVA: >>>> lxml===4.4.1 nova tests fail https://bugs.launchpad.net/nova/+bug/1838666 > > Sean Mooney agreed to take a look at this one. > >>>> websockify===0.9.0 tempest test failing > > This is now known as bug 1840788 [1]. > > I did some initial investigation and tried to fix it. Turned out my fix > was already part of another change. But it also turns out that that fix > is only part of the solution. See the bug report for (links to) details. > > At this point, it needs someone who understands what test_novnc [2] is > actually trying to do. Because I don't. > > Anyone? From the test run on your patch [3], it looks like we're going to need a change in nova as well in nova/console/websocketproxy.py [4]: AttributeError: module 'websockify' has no attribute 'WebSocketServer' It looks like the WebSocketServer class got moved from websockify.websocket to websockify.websocketserver in v0.9.0: https://github.com/novnc/websockify/commit/8a697622495fd319582cd1c604e7eb2cc0ac0ef6#diff-308aaa63704b4177c97728bfa9cb0183 and thus is no longer accessible via the top level 'websockify' module as a result: https://github.com/novnc/websockify/blob/v0.9.0/websockify/__init__.py Since this is a change to upper-constraints to allow v0.9.0, we will need a way for it to work with both module layouts, yeah? Cheers, -melanie [3] https://review.opendev.org/677798 [4] https://zuul.opendev.org/t/openstack/build/e0a8a19021b64350a0a55cc08f374d02/log/controller/logs/screen-n-novnc-cell1.txt.gz#20-51 > Thanks, > efried > > [1] https://bugs.launchpad.net/nova/+bug/1840788 > [2] > https://opendev.org/openstack/tempest/src/branch/master/tempest/api/compute/servers/test_novnc.py#L180 >