<div dir="ltr">The actual problem is that the manifest isn't idempotent anymore:<div><a href="http://logs.openstack.org/47/575147/16/check/puppet-openstack-beaker-centos-7/3f70cc9/job-output.txt.gz#_2018-07-04_00_42_19_705516">http://logs.openstack.org/47/575147/16/check/puppet-openstack-beaker-centos-7/3f70cc9/job-output.txt.gz#_2018-07-04_00_42_19_705516</a><br></div><div>So something in your patch is breaking the Keystone_domain provider and makes it non idempotent.</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 3, 2018 at 7:30 PM Lars Kellogg-Stedman <<a href="mailto:lars@redhat.com">lars@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I need another set of eyes.<br>
<br>
I have a review that keeps failing here:<br>
<br>
  <a href="http://logs.openstack.org/47/575147/16/check/puppet-openstack-beaker-centos-7/3f70cc9/job-output.txt.gz#_2018-07-04_00_42_19_696966" rel="noreferrer" target="_blank">http://logs.openstack.org/47/575147/16/check/puppet-openstack-beaker-centos-7/3f70cc9/job-output.txt.gz#_2018-07-04_00_42_19_696966</a><br>
<br>
It's looking for the regular expression:<br>
<br>
  /Puppet::Type::Keystone_tenant::ProviderOpenstack: Support for a resource without the domain.*using 'Default'.*default domain id is '/<br>
<br>
The output shown in the failure message contains:<br>
<br>
  [1;33mWarning: Puppet::Type::Keystone_tenant::ProviderOpenstack:<br>
  Support for a resource without the domain set is deprecated in<br>
  Liberty cycle. It will be dropped in the M-cycle. Currently using<br>
  'Default' as default domain name while the default domain id is<br>
  '7ddf1dfa7fac46679ba7ae2245bece2f'.[0m<br>
<br>
The regular expression matches the text! The failing test is here:<br>
<br>
  <a href="https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/default_domain_spec.rb#L59" rel="noreferrer" target="_blank">https://github.com/openstack/puppet-keystone/blob/master/spec/acceptance/default_domain_spec.rb#L59</a><br>
<br>
I've been staring at this for a while and I'm not sure what's going<br>
on.<br>
<br>
-- <br>
Lars Kellogg-Stedman <<a href="mailto:lars@redhat.com" target="_blank">lars@redhat.com</a>> | larsks @ {irc,twitter,github}<br>
<a href="http://blog.oddbit.com/" rel="noreferrer" target="_blank">http://blog.oddbit.com/</a>                |<br>
<br>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">Emilien Macchi<br></div></div>