<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<tt>Thanks a bunch for digging into this, Tony. I'll follow up with
the oauthlib maintainers and see if they'd be interested in these
changes upstream. If so, I can chip away at it. For now we'll have
to settle for not treating warnings as errors to unblock our
documentation gate [0].<br>
<br>
[0] <a class="moz-txt-link-freetext" href="https://review.openstack.org/#/c/577974/">https://review.openstack.org/#/c/577974/</a><br>
</tt><br>
<div class="moz-cite-prefix">On 06/25/2018 07:27 PM, Tony Breeds
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:20180626002729.GB21570@thor.bakeyournoodle.com">
<pre wrap="">On Mon, Jun 25, 2018 at 05:42:00PM -0500, Lance Bragstad wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Keystone is hitting this, too [0]. I attempted the same solution that
Tony posted, but no luck. I've even gone so far as removing every
comment from the module to see if that helps narrow down the problem
area, but sphinx still trips. The output from the error message isn't
very descriptive either. Has anyone else had issues fixing this for
python comments, not just docstrings?
[0] <a class="moz-txt-link-freetext" href="https://bugs.launchpad.net/keystone/+bug/1778603">https://bugs.launchpad.net/keystone/+bug/1778603</a>
</pre>
</blockquote>
<pre wrap="">
I did a little digging for the keystone problem and it's due to a
missing ':' in
<a class="moz-txt-link-freetext" href="https://github.com/oauthlib/oauthlib/blob/master/oauthlib/oauth1/rfc5849/request_validator.py#L819-L820">https://github.com/oauthlib/oauthlib/blob/master/oauthlib/oauth1/rfc5849/request_validator.py#L819-L820</a>
So the correct way to fix this is to correct that in oauthlib, get it
released and use that.
I hit additional problems in that enabling -W in oauthlib, to pevent
this happening in the future, lead me down a rabbit hole I don't really
have cycles to dig out of.
Here's a dump of where I got to[1]. Clearly it mixes "fixes" with
debugging but it isn't too hard to reproduce and someone that knows more
Sphinx will be able to understand the errors better than I can.
[1] <a class="moz-txt-link-freetext" href="http://paste.openstack.org/show/724271/">http://paste.openstack.org/show/724271/</a>
Yours Tony.
</pre>
<!--'"--><br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: <a class="moz-txt-link-abbreviated" href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<a class="moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</body>
</html>