<div dir="ltr"><div><div><div><div>Hi Gilles, I just had a look at your patch, cool, thanks for the work.<br><br></div>ok, that good to start with a limited subsets of query types indeed, you're right.<br><br></div>Ok, perfect for the patch to branch, I don't know why but I had the feeling that you were requesting for the branch to be merged back and not for the patch :D I just read my emails too quickly I suppose.<br><br></div>About your code, I feel that we should extract the schemas from the base.py under neutron/api/graphql/schemas/ right now before the code became to large, that would then allows for a better granularity.<br><br></div>Thanks.<br><div><br><div class="gmail_quote"><div dir="ltr">Le ven. 22 juin 2018 à 08:42, Gilles Dubreuil <<a href="mailto:gdubreui@redhat.com" target="_blank">gdubreui@redhat.com</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="m_2627054885624337352m_4875025959815023147moz-cite-prefix">On 22/06/18 15:57, Flint WALRUS wrote:<br>
</div>
</div><div text="#000000" bgcolor="#FFFFFF"><blockquote type="cite">Hi
everyone,<br>
<br></blockquote></div><div text="#000000" bgcolor="#FFFFFF"><blockquote type="cite">
Thanks for the updates and support, that appreciated.<br>
<br>
@Gilles, did you already implemented all the service types?<br>
</blockquote></div><div text="#000000" bgcolor="#FFFFFF"><blockquote type="cite"></blockquote>
<br>
We have query types for networks and subnets for now.<br>
Before we add more we are going to focus on oslo policies so we can
access and modify those items in respect of the existing security
approach. <br>
Then we will have a solid foundation to add more types.</div><div text="#000000" bgcolor="#FFFFFF"><br>
<br>
<blockquote type="cite"><br>
What is left to do? You already want to merge the feature branch
with master?<br>
</blockquote>
<br></div><div text="#000000" bgcolor="#FFFFFF">
The feature branch graphql is the Proof of Concept and won't be
merged to master until we have it full ready to share/demonstrate it
to others.<br>
So we're pushing patches against that branch. The initial one to be
hopefully merged soon.</div><div text="#000000" bgcolor="#FFFFFF"><br>
<br>
<blockquote type="cite"><br>
@tristan I’d like to work on the feature branch but I’ll wait for
gilles answers as I don’t want to mess up having pieces of code
everywhere.<br>
<br>
Thanks!<br>
<div class="gmail_quote">
<div dir="ltr">Le ven. 22 juin 2018 à 06:44, Gilles Dubreuil
<<a href="mailto:gdubreui@redhat.com" target="_blank">gdubreui@redhat.com</a>> a écrit :<br>
</div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF"> <br>
<div class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-cite-prefix">On
22/06/18 09:21, Tristan Cacqueray wrote:<br>
</div>
<blockquote type="cite">Hi Flint, <br>
<br>
On June 21, 2018 5:32 pm, Flint WALRUS wrote: <br>
<blockquote type="cite">Hi everyone, sorry for the late
answer but I’m currently trapped into a <br>
cluster issue with cinder-volume that doesn’t give me
that much time. <br>
<br>
That being said, I’ll have some times to work on this
feature during the <br>
summer (July/August) and so do some coding once I’ll
have catched up with <br>
your work. <br>
<br>
</blockquote>
That's great to hear! The next step is to understand how
to deal with <br>
oslo policy and control objects access/modification. <br>
<br>
<blockquote type="cite">Did you created a specific tree or
did you created a new graphql folder <br>
within the neutron/neutron/api/ path regarding the
schemas etc? <br>
</blockquote>
<br>
There is a feature/graphql branch were an initial patch[1]
adds a new <br>
neutron/api/graphql directory as well as a new
test_graphql.py <br>
functional tests. <br>
The api-paste is also updated to expose the '/graphql'
http endpoint. <br>
<br>
Not sure if we want to keep on updating that change, or
propose further <br>
code as new change on top of this skeleton? <br>
<br>
</blockquote>
<br>
</div>
<div text="#000000" bgcolor="#FFFFFF"> Makes sense to merge
it, I think we have the base we needed to get going.<br>
I'll make it green so we can get merge it. <br>
</div>
<div text="#000000" bgcolor="#FFFFFF"> <br>
<br>
<blockquote type="cite">Regards, <br>
-Tristan <br>
<br>
<br>
<blockquote type="cite">Le sam. 16 juin 2018 à 08:42,
Tristan Cacqueray <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-rfc2396E" href="mailto:tdecacqu@redhat.com" target="_blank"><tdecacqu@redhat.com></a>
a <br>
écrit : <br>
<br>
<blockquote type="cite">On June 15, 2018 10:42 pm,
Gilles Dubreuil wrote: <br>
> Hello, <br>
> <br>
> This initial patch [1] allows to retrieve
networks, subnets. <br>
> <br>
> This is very easy, thanks to the
graphene-sqlalchemy helper. <br>
> <br>
> The edges, nodes layer might be confusing at
first meanwhile they make <br>
> the Schema Relay-compliant in order to offer
re-fetching, pagination <br>
> features out of the box. <br>
> <br>
> The next priority is to set the unit test in
order to implement <br>
mutations. <br>
> <br>
> Could someone help provide a base in order to
respect Neutron test <br>
> requirements? <br>
> <br>
> <br>
> [1] [abandoned] <br>
<br>
Actually, the correct review (proposed on the
feature/graphql branch) <br>
is: <br>
<br>
[1] <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-freetext" href="https://review.openstack.org/575898" target="_blank">https://review.openstack.org/575898</a>
<br>
<br>
> <br>
> Thanks, <br>
> Gilles <br>
> <br>
> <br>
__________________________________________________________________________
<br>
> OpenStack Development Mailing List (not for usage
questions) <br>
> Unsubscribe: <br>
<a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-abbreviated" href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<br>
> <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
<br>
> <br>
__________________________________________________________________________
<br>
OpenStack Development Mailing List (not for usage
questions) <br>
Unsubscribe: <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-abbreviated" href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<br>
<a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
<br>
<br>
</blockquote>
__________________________________________________________________________
<br>
OpenStack Development Mailing List (not for usage
questions) <br>
Unsubscribe: <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-abbreviated" href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<br>
<a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
<br>
<br>
</blockquote>
<br>
<fieldset class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472mimeAttachmentHeader"></fieldset>
<br>
<pre>__________________________________________________________________________
OpenStack Development Mailing List (not for usage questions)
Unsubscribe: <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-abbreviated" href="mailto:OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a>
<a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-freetext" href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a>
</pre>
</blockquote>
<br>
</div>
<div text="#000000" bgcolor="#FFFFFF">
<pre class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-signature" cols="72">--
Gilles Dubreuil
Senior Software Engineer - Red Hat - Openstack DFG Integration
Email: <a class="m_2627054885624337352m_4875025959815023147m_-3843358409638826472moz-txt-link-abbreviated" href="mailto:gilles@redhat.com" target="_blank">gilles@redhat.com</a>
GitHub/IRC: gildub
Mobile: <a href="tel:+61%20400%20894%20219" value="+61400894219" target="_blank">+61 400 894 219</a>
</pre>
</div>
__________________________________________________________________________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.openstack.org?subject:unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a><br>
</blockquote>
</div>
</blockquote>
<br>
<pre class="m_2627054885624337352m_4875025959815023147moz-signature" cols="72">--
Gilles Dubreuil
Senior Software Engineer - Red Hat - Openstack DFG Integration
Email: <a class="m_2627054885624337352m_4875025959815023147moz-txt-link-abbreviated" href="mailto:gilles@redhat.com" target="_blank">gilles@redhat.com</a>
GitHub/IRC: gildub
Mobile: <a href="tel:+61%20400%20894%20219" value="+61400894219" target="_blank">+61 400 894 219</a>
</pre>
</div></blockquote></div></div></div>