<html><body><p><font size="2">Thanks all for helping , Saw this patch [1] merged and assume that's the fix for the issue , we will rebase based on it then try again,</font><br><br><font size="2">[1] </font><a href="https://review.openstack.org/#/c/575872/4"><font size="2">https://review.openstack.org/#/c/575872/4</font></a><br><br><font size="2">Best Regards! <br><br>Kevin (Chen) Ji ¼Í ³¿<br><br>Engineer, zVM Development, CSTL<br>Notes: Chen CH Ji/China/IBM@IBMCN Internet: jichenjc@cn.ibm.com<br>Phone: +86-10-82451493<br>Address: 3/F Ring Building, ZhongGuanCun Software Park, Haidian District, Beijing 100193, PRC </font><br><br><img width="16" height="16" src="cid:1__=8FBB0823DFA9F0D18f9e8a93df938690918c8FB@" border="0" alt="Inactive hide details for Doug Hellmann ---06/16/2018 08:14:32 AM---Excerpts from Eric Fried's message of 2018-06-15 18:09:49 -"><font size="2" color="#424282">Doug Hellmann ---06/16/2018 08:14:32 AM---Excerpts from Eric Fried's message of 2018-06-15 18:09:49 -0500: > Doug-</font><br><br><font size="2" color="#5F5F5F">From: </font><font size="2">Doug Hellmann <doug@doughellmann.com></font><br><font size="2" color="#5F5F5F">To: </font><font size="2">openstack-dev <openstack-dev@lists.openstack.org></font><br><font size="2" color="#5F5F5F">Date: </font><font size="2">06/16/2018 08:14 AM</font><br><font size="2" color="#5F5F5F">Subject: </font><font size="2">Re: [openstack-dev] [requirements][nova] weird error on 'Validating lower constraints of test-requirements.txt'</font><br><hr width="100%" size="2" align="left" noshade style="color:#8091A5; "><br><br><br><tt><font size="2">Excerpts from Eric Fried's message of 2018-06-15 18:09:49 -0500:<br>> Doug-<br>> <br>> > The lower constraints tests only look at files in the same repo.<br>> > The minimum versions of dependencies set in requirements.txt,<br>> > test-requirements.txt, etc. need to match the values in<br>> > lower-constraints.txt.<br>> > <br>> > In this case, the more detailed error message is a few lines above the<br>> > error quoted by Chen CH Ji. The detail say "Requirement for package<br>> > retrying has no lower bound" which means that there is a line in<br>> > requirements.txt indicating a dependency on "retrying" but without<br>> > specifying a minimum version. That is the problem.<br>> <br>> The patch didn't change the retrying constraint in requirements.txt [1];<br>> why isn't this same failure affecting every other patch in nova?<br>> <br>> [1] </font></tt><tt><font size="2"><a href="https://review.openstack.org/#/c/523387/51/requirements.txt@65">https://review.openstack.org/#/c/523387/51/requirements.txt@65</a></font></tt><tt><font size="2"><br>> <br>> -efried<br>> <br><br>Earlier this cycle I updated the requirements check job to verify<br>that all of the settings are correct any time any changes to the<br>dependency lists are made. We used to only look at the line being<br>changed, but that allowed incorrect settings to stay in place for<br>a long time so we weren't actually testing with good settings. We<br>still only run that job when the dependency list is modified in<br>some way.<br><br>Earlier this week, Matt Thode updated the job to be more strict and<br>to require that all dependencies have a minimum version specified<br>[2]. We did this because some project teams thought that after we<br>dropped the minimums from the global-requirements.txt list they<br>were supposed to (or allowed to) drop them from their project<br>dependency lists, too.<br><br>My guess is that this dependency in nova never had a lower bound and<br>that this is the first patch to touch the dependency list, so now it's<br>being blocked on the fact that the list has a validation error.<br><br>I recommend using a separate patch to fix the minimum version of<br>retrying and then rebasing 523387 on top of the new patch.<br><br>Doug<br><br>[2] </font></tt><tt><font size="2"><a href="https://review.openstack.org/#/c/574367/">https://review.openstack.org/#/c/574367/</a></font></tt><tt><font size="2"><br><br>__________________________________________________________________________<br>OpenStack Development Mailing List (not for usage questions)<br>Unsubscribe: OpenStack-dev-request@lists.openstack.org?subject:unsubscribe<br></font></tt><tt><font size="2"><a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev">http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev</a></font></tt><tt><font size="2"><br><br></font></tt><br><br><BR>
</body></html>