<div dir="ltr">Zane,<div><br></div><div>Not sure it is to be honest.:)</div><div><br></div><div>Amy (spotz)</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Jun 4, 2018 at 7:29 AM, Zane Bitter <span dir="ltr"><<a href="mailto:zbitter@redhat.com" target="_blank">zbitter@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 04/06/18 10:19, Amy Marrich wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Zane,<br>
<br>
I'll read in more detail, but do we want to add rollcall-vote?<br>
</blockquote>
<br></span>
Is it used anywhere other than in the governance repo? We certainly could add it, but it didn't seem like a top priority.<br>
<br>
- ZB<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Amy (spotz)<div><div class="h5"><br>
<br>
On Mon, Jun 4, 2018 at 7:13 AM, Zane Bitter <<a href="mailto:zbitter@redhat.com" target="_blank">zbitter@redhat.com</a> <mailto:<a href="mailto:zbitter@redhat.com" target="_blank">zbitter@redhat.com</a>>> wrote:<br>
<br>
On 31/05/18 14:35, Julia Kreger wrote:<br>
<br>
Back to the topic of nitpicking!<br>
<br>
I virtually sat down with Doug today and we hammered out the<br>
positive<br>
aspects that we feel like are the things that we as a community want<br>
to see as part of reviews coming out of this effort. The principles<br>
change[1] in governance has been updated as a result.<br>
<br>
I think we are at a point where we have to state high level<br>
principles, and then also update guidelines or other context<br>
providing<br>
documentation to re-enforce some of items covered in this<br>
discussion... not just to educate new contributors, but to serve<br>
as a<br>
checkpoint for existing reviewers when making the decision as to how<br>
to vote change set. The question then becomes where would such<br>
guidelines or documentation best fit?<br>
<br>
<br>
I think the contributor guide is the logical place for it. Kendall<br>
pointed out this existing section:<br>
<br>
<a href="https://docs.openstack.org/contributors/code-and-documentation/using-gerrit.html#reviewing-changes" rel="noreferrer" target="_blank">https://docs.openstack.org/con<wbr>tributors/code-and-documentati<wbr>on/using-gerrit.html#<wbr>reviewing-changes</a><br>
<<a href="https://docs.openstack.org/contributors/code-and-documentation/using-gerrit.html#reviewing-changes" rel="noreferrer" target="_blank">https://docs.openstack.org/co<wbr>ntributors/code-and-documentat<wbr>ion/using-gerrit.html#<wbr>reviewing-changes</a>><br>
<br>
It could go in there, or perhaps we separate out the parts about<br>
when to use which review scores into a separate page from the<br>
mechanics of how to use Gerrit.<br>
<br>
Should we explicitly detail the<br>
cause/effect that occurs? Should we convey contributor<br>
perceptions, or<br>
maybe even just link to this thread as there has been a massive<br>
amount<br>
of feedback raising valid cases, points, and frustrations.<br>
<br>
Personally, I'd lean towards a blended approach, but the question of<br>
where is one I'm unsure of. Thoughts?<br>
<br>
<br>
Let's crowdsource a set of heuristics that reviewers and<br>
contributors should keep in mind when they're reviewing or having<br>
their changes reviewed. I made a start on collecting ideas from this<br>
and past threads, as well as my own reviewing experience, into a<br>
document that I've presumptuously titled "How to Review Changes the<br>
OpenStack Way" (but might be more accurately called "The Frank<br>
Sinatra Guide to Code Review" at the moment):<br>
<br>
<a href="https://etherpad.openstack.org/p/review-the-openstack-way" rel="noreferrer" target="_blank">https://etherpad.openstack.org<wbr>/p/review-the-openstack-way</a><br>
<<a href="https://etherpad.openstack.org/p/review-the-openstack-way" rel="noreferrer" target="_blank">https://etherpad.openstack.or<wbr>g/p/review-the-openstack-way</a>><br>
<br>
It's in an etherpad to make it easier for everyone to add their<br>
suggestions and comments (folks in #openstack-tc have made some<br>
tweaks already). After a suitable interval has passed to collect<br>
feedback, I'll turn this into a contributor guide change.<br>
<br>
Have at it!<br>
<br>
cheers,<br>
Zane.<br>
<br>
<br>
-Julia<br>
<br>
[1]: <a href="https://review.openstack.org/#/c/570940/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/570940/</a><br>
<<a href="https://review.openstack.org/#/c/570940/" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>#/c/570940/</a>><br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe:<br>
<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br></div></div>
<<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@<wbr>lists.openstack.org?subject:un<wbr>subscribe</a>><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cg<wbr>i-bin/mailman/listinfo/opensta<wbr>ck-dev</a>><span class=""><br>
<br>
<br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
</span></blockquote><div class="HOEnZb"><div class="h5">
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></div></blockquote></div><br></div>