<html xmlns="http://www.w3.org/1999/xhtml">
<head>
<title></title>
</head>
<body>
<div name="messageBodySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;">Yep, agree that this is a bug. We need to fix that. Would you please create a ticket at LP?</div>
<div name="messageSignatureSection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
Thanks<br />
<br />
Renat Akhmerov<br />
@Nokia</div>
<div name="messageReplySection" style="font-size: 14px; font-family: -apple-system, BlinkMacSystemFont, sans-serif;"><br />
On 27 Apr 2018, 12:53 +0700, Vitalii Solodilov <mcdkr@yandex.ru>, wrote:<br />
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #1abc9c;">
<div>> No matter at what stage the task is, but if it’s still in RUNNING state or FAILED but we know that retry policy still didn’t use all attempts then the ‘timeout’ policy should force the task to fail.</div>
<div>Ok, then we have a bug because timeout policy doesn't force the task to fail. It retries task. And after that, we have two running action parallel.</div>
<div>https://github.com/openstack/mistral/blob/master/mistral/engine/policies.py#L537</div>
<div> </div>
<div>27.04.2018, 07:50, "Renat Akhmerov" <renat.akhmerov@gmail.com>:</div>
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #e67e22;">
<div style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif;">Hi,
<div> </div>
<div>I don’t clearly understand the problem you’re trying to point to.</div>
<div> </div>
<div>IMO, when using these two policies at the same time ‘timeout’ policy should have higher priority. No matter at what stage the task is, but if it’s still in RUNNING state or FAILED but we know that retry policy still didn’t use all attempts then the ‘timeout’ policy should force the task to fail. If it’s the second case when it’s FAILED but the retry policy is still in play then we need to leave some ‘force’ marker in the task state to make sure that there’s no need to retry it further.</div>
</div>
<div style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif;"><br />
Thanks<br />
<br />
Renat Akhmerov<br />
@Nokia</div>
<div style="font-size:14px;font-family:-apple-system,BlinkMacSystemFont,sans-serif;"><br />
On 24 Apr 2018, 05:00 +0700, Vitalii Solodilov <<a href="mailto:mcdkr@yandex.ru">mcdkr@yandex.ru</a>>, wrote:
<blockquote type="cite" style="margin: 5px 5px; padding-left: 10px; border-left: thin solid #3498db;">Hi Renat, Can you explain me and Dougal how timeout policy should work with retry policy?<br />
<br />
I guess there is bug right now.<br />
The behaviour is something like this <a href="https://ibb.co/hhm0eH">https://ibb.co/hhm0eH</a><br />
Example: <a href="https://review.openstack.org/#/c/563759/">https://review.openstack.org/#/c/563759/</a><br />
Logs: <a href="http://logs.openstack.org/59/563759/1/check/openstack-tox-py27/6f38808/job-output.txt.gz#_2018-04-23_20_54_55_376083">http://logs.openstack.org/59/563759/1/check/openstack-tox-py27/6f38808/job-output.txt.gz#_2018-04-23_20_54_55_376083</a><br />
Even we will fix this bug and after task timeout we will not retry task. I don't understand which problem is decided by this timeout and retry.<br />
Other problem. What about task retry? I mean using mistral api. The problem is that timeout delayed calls was not created.<br />
<br />
IMHO the combination of these policies should work like this <a href="https://ibb.co/fe5tzH">https://ibb.co/fe5tzH</a><br />
It is not a timeout per action because when task retry it move to some complete state and then back to RUNNING state. And it will work fine with with-items policy.<br />
The main advantage is executor and rabbitmq HA. I can specify small timeout if executor will die the task retried by timeout and create new action.<br />
The second is predictable behaviour. When I specify timeout: 10 and retry.count: 5 I know that will be create maximum 5 action before SUCCESS state and every action will be executes no longer than 10 seconds.<br />
<br />
-- <br />
Best regards,<br />
<br />
Vitalii Solodilov<br />
</blockquote>
</div>
</blockquote>
<div> </div>
<div> </div>
<div>-- </div>
<div><span style="background-color:#ffffff;color:#000000;display:inline !important;float:none;font-family:arial,sans-serif;font-size:15px;font-style:normal;font-variant-caps:normal;font-variant-ligatures:normal;font-weight:normal;text-align:start;text-transform:none;white-space:pre-wrap;">Best regards,</span></div>
<div> </div>
<div><span style="background-color:#ffffff;color:#000000;display:inline !important;float:none;font-family:arial,sans-serif;font-size:15px;font-style:normal;font-variant-caps:normal;font-variant-ligatures:normal;font-weight:normal;text-align:start;text-transform:none;white-space:pre-wrap;">Vitalii Solodilov</span></div>
<div> </div>
</blockquote>
</div>
</body>
</html>