<div dir="ltr">Hi <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">horizon plugin developers,</span><div><br></div><div>As I announced in the quoted mail, Rocky-1 was released and mox is NOT prepared in the horizon test helpers by default now [1].</div><div>If your horizon plugin still depends on mox, please ensure to set use_mox = True in your test classes.</div><div><div><br></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">> 2) After Rocky-1, use_mox of openstack_dashboard.test.</span><wbr style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">helpers.TestCase </span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">will be changed from True to False.</span><br style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">> This means your plugin needs to set use_mox to True explicitly if </span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">your unit tests still depends on mox.</span><br style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">> Our suggestion is to set use_mox=True until Rocky-1 milestone if </span><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">your tests depends on mox not to break your gate.</span><br style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"><br>[1] <a href="https://review.openstack.org/558048">https://review.openstack.org/558048</a></div><div><br></div><div>Thanks,<br></div><div>Akihiro Motoki (amotoki)</div><div><div><br></div><div><div class="gmail_extra"><div class="gmail_quote">2018-03-18 17:54 GMT+09:00 Akihiro Motoki <span dir="ltr"><<a href="mailto:amotoki@gmail.com" target="_blank">amotoki@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi horizon plugin developers,<br>
<br>
As you know, mox-removal is one of the community goal in Rocky and<br>
horizon team is working on removing usage of mox [1].<br>
<br>
This mail announces the plan of dropping mox dependencies in horizon<br>
test helpers (horizon.test.helpers.TestCase and/or<br>
openstack_dashboard.test.<wbr>helpers.TestCase).<br>
<br>
1) The first step is to introduce "use_mox" flag in<br>
horizon.test.helpers.TestCase. The flag is available now.<br>
If you set the flag to False, you can run your plugin test without mox.<br>
The default value of use_mox is False for<br>
horizon.test.helpers.TestCase [2] and True for<br>
openstack_dashboard.test.<wbr>helpers.TestCase [3].<br>
<br>
2) After Rocky-1, use_mox of openstack_dashboard.test.<wbr>helpers.TestCase<br>
will be changed from True to False.<br>
This means your plugin needs to set use_mox to True explicitly if<br>
your unit tests still depends on mox.<br>
Our suggestion is to set use_mox=True until Rocky-1 milestone if<br>
your tests depends on mox not to break your gate.<br>
<br>
3) After Rocky RC1 is released, "use_mox" flag in the horizon repo<br>
will be dropped.<br>
This means use_mox flag will no longer be in effect.<br>
If your plugin tests still depends on mox at this stage, your<br>
plugin test needs to set up mox explicitly.<br>
<br>
Thanks,<br>
Akihiro Motoki (amotoki)<br>
<br>
[1] <a href="https://blueprints.launchpad.net/horizon/+spec/mock-framework-in-unit-tests" rel="noreferrer" target="_blank">https://blueprints.launchpad.<wbr>net/horizon/+spec/mock-<wbr>framework-in-unit-tests</a><br>
[2] <a href="https://github.com/openstack/horizon/blob/6e29fdde1edc67a6797eba2c3f9c557f840d4ea7/horizon/test/helpers.py#L138" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>horizon/blob/<wbr>6e29fdde1edc67a6797eba2c3f9c55<wbr>7f840d4ea7/horizon/test/<wbr>helpers.py#L138</a><br>
[3] <a href="https://github.com/openstack/horizon/blob/6e29fdde1edc67a6797eba2c3f9c557f840d4ea7/openstack_dashboard/test/helpers.py#L257" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>horizon/blob/<wbr>6e29fdde1edc67a6797eba2c3f9c55<wbr>7f840d4ea7/openstack_<wbr>dashboard/test/helpers.py#L257</a><br>
</blockquote></div><br></div></div></div></div></div>