<div dir="ltr">Glancing at the code[0], it looks like cotyledon has this built in already.<div>Though, you'll probably want to pass in reload_method='mutate' like the</div><div>oslo docs suggest[1].</div><div><br></div><div>[0] <a href="https://github.com/sileht/cotyledon/blob/master/cotyledon/oslo_config_glue.py#L68">https://github.com/sileht/cotyledon/blob/master/cotyledon/oslo_config_glue.py#L68</a></div><div>[1] <a href="https://docs.openstack.org/oslo.config/latest/reference/mutable.html#calling-mutate-config-files">https://docs.openstack.org/oslo.config/latest/reference/mutable.html#calling-mutate-config-files</a></div><div><br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><br>// jim</div></div>
<br><div class="gmail_quote">On Tue, Mar 27, 2018 at 12:20 PM, Michael Johnson <span dir="ltr"><<a href="mailto:johnsomor@gmail.com" target="_blank">johnsomor@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Does anyone know how this will work with services that are using<br>
cotyledon instead of oslo.service (for eliminating eventlet)?<br>
<span class="HOEnZb"><font color="#888888"><br>
Michael<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
On Mon, Mar 26, 2018 at 5:35 AM, Sławomir Kapłoński <<a href="mailto:slawek@kaplonski.pl">slawek@kaplonski.pl</a>> wrote:<br>
> Hi,<br>
><br>
><br>
>> Wiadomość napisana przez ChangBo Guo <<a href="mailto:glongwave@gmail.com">glongwave@gmail.com</a>> w dniu 26.03.2018, o godz. 14:15:<br>
>><br>
>><br>
>> 2018-03-22 16:12 GMT+08:00 Sławomir Kapłoński <<a href="mailto:slawek@kaplonski.pl">slawek@kaplonski.pl</a>>:<br>
>> Hi,<br>
>><br>
>> I took care of implementation of [1] in Neutron and I have couple questions to about this goal.<br>
>><br>
>> 1. Should we only change "restart_method" to mutate as is described in [2] ? I did already something like that in [3] - is it what is expected?<br>
>><br>
>>      Yes , let's the only  thing.  we need test if that if it works .<br>
><br>
> Ok, so please take a look at my patch for neutron if that is what we should do :)<br>
><br>
>><br>
>> 2. How I can check if this change is fine and config option are mutable exactly? For now when I change any config option for any of neutron agents and send SIGHUP to it it is in fact "restarted" and config is reloaded even with this old restart method.<br>
>><br>
>>     good question, we indeed thought this question when we proposal  the goal.  But It seems difficult to test  that consuming projects like Neutron automatically.<br>
><br>
> I was asking rather about some manual test instead of automatic one.<br>
><br>
>><br>
>> 3. Should we add any automatic tests for such change also? Any examples of such tests in other projects maybe?<br>
>>      There is no example for tests now, we only have some unit tests  in oslo.service .<br>
>><br>
>> [1] <a href="https://governance.openstack.org/tc/goals/rocky/enable-mutable-configuration.html" rel="noreferrer" target="_blank">https://governance.openstack.<wbr>org/tc/goals/rocky/enable-<wbr>mutable-configuration.html</a><br>
>> [2] <a href="https://docs.openstack.org/oslo.config/latest/reference/mutable.html" rel="noreferrer" target="_blank">https://docs.openstack.org/<wbr>oslo.config/latest/reference/<wbr>mutable.html</a><br>
>> [3] <a href="https://review.openstack.org/#/c/554259/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/554259/</a><br>
>><br>
>> —<br>
>> Best regards<br>
>> Slawek Kaplonski<br>
>> <a href="mailto:slawek@kaplonski.pl">slawek@kaplonski.pl</a><br>
>><br>
>><br>
>> ______________________________<wbr>______________________________<wbr>______________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>><br>
>><br>
>><br>
>> --<br>
>> ChangBo Guo(gcb)<br>
>> Community Director @EasyStack<br>
>> ______________________________<wbr>______________________________<wbr>______________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
> —<br>
> Best regards<br>
> Slawek Kaplonski<br>
> <a href="mailto:slawek@kaplonski.pl">slawek@kaplonski.pl</a><br>
><br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div>