<div dir="ltr">Hi Kaz,<div><br></div><div>These repositories are under horizon project. It looks better to keep the current core team.</div><div>It potentially brings some confusion if we treat some horizon plugin team specially.</div><div>Reviewing xstatic repos would be a small burden, wo I think it would work without problem even if only horizon-core can approve xstatic reviews.</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">2018-03-20 10:02 GMT+09:00 Kaz Shinohara <span dir="ltr"><<a href="mailto:ksnhr.tech@gmail.com" target="_blank">ksnhr.tech@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Ivan, Horizon folks,<br>
<br>
<br>
Now totally 8 xstatic-** repos for heat-dashboard have been landed.<br>
<br>
In project-config for them, I've set same acl-config as the existing<br>
xstatic repos.<br>
It means only "xstatic-core" can manage the newly created repos on gerrit.<br>
Could you kindly add "heat-dashboard-core" into "xstatic-core" like as<br>
what horizon-core is doing ?<br>
<br>
xstatic-core<br>
<a href="https://review.openstack.org/#/admin/groups/385,members" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/admin/groups/385,members</a><br>
<br>
heat-dashboard-core<br>
<a href="https://review.openstack.org/#/admin/groups/1844,members" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/admin/groups/1844,members</a><br>
<br>
Of course, we will surely touch only what we made, just would like to<br>
manage them smoothly by ourselves.<br>
In case we need to touch the other ones, will ask Horizon team for help.<br>
<br>
Thanks in advance.<br>
<br>
Regards,<br>
Kaz<br>
<div class="HOEnZb"><div class="h5"><br>
<br>
2018-03-14 15:12 GMT+09:00 Xinni Ge <<a href="mailto:xinni.ge1990@gmail.com">xinni.ge1990@gmail.com</a>>:<br>
> Hi Horizon Team,<br>
><br>
> I reported a bug about lack of ``ADD_XSTATIC_MODULES`` plugin option,<br>
> and submitted a patch for it.<br>
> Could you please help to review the patch.<br>
><br>
> <a href="https://bugs.launchpad.net/horizon/+bug/1755339" rel="noreferrer" target="_blank">https://bugs.launchpad.net/<wbr>horizon/+bug/1755339</a><br>
> <a href="https://review.openstack.org/#/c/552259/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/552259/</a><br>
><br>
> Thank you very much.<br>
><br>
> Best Regards,<br>
> Xinni<br>
><br>
> On Tue, Mar 13, 2018 at 6:41 PM, Ivan Kolodyazhny <<a href="mailto:e0ne@e0ne.info">e0ne@e0ne.info</a>> wrote:<br>
>><br>
>> Hi Kaz,<br>
>><br>
>> Thanks for cleaning this up. I put +1 on both of these patches<br>
>><br>
>> Regards,<br>
>> Ivan Kolodyazhny,<br>
>> <a href="http://blog.e0ne.info/" rel="noreferrer" target="_blank">http://blog.e0ne.info/</a><br>
>><br>
>> On Tue, Mar 13, 2018 at 4:48 AM, Kaz Shinohara <<a href="mailto:ksnhr.tech@gmail.com">ksnhr.tech@gmail.com</a>><br>
>> wrote:<br>
>>><br>
>>> Hi Ivan & Horizon folks,<br>
>>><br>
>>><br>
>>> Now we are submitting a couple of patches to have the new xstatic<br>
>>> modules.<br>
>>> Let me request you to have review the following patches.<br>
>>> We need Horizon PTL's +1 to move these forward.<br>
>>><br>
>>> project-config<br>
>>> <a href="https://review.openstack.org/#/c/551978/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/551978/</a><br>
>>><br>
>>> governance<br>
>>> <a href="https://review.openstack.org/#/c/551980/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/551980/</a><br>
>>><br>
>>> Thanks in advance:)<br>
>>><br>
>>> Regards,<br>
>>> Kaz<br>
>>><br>
>>><br>
>>> 2018-03-12 20:00 GMT+09:00 Radomir Dopieralski <<a href="mailto:openstack@sheep.art.pl">openstack@sheep.art.pl</a>>:<br>
>>> > Yes, please do that. We can then discuss in the review about technical<br>
>>> > details.<br>
>>> ><br>
>>> > On Mon, Mar 12, 2018 at 2:54 AM, Xinni Ge <<a href="mailto:xinni.ge1990@gmail.com">xinni.ge1990@gmail.com</a>><br>
>>> > wrote:<br>
>>> >><br>
>>> >> Hi, Akihiro<br>
>>> >><br>
>>> >> Thanks for the quick reply.<br>
>>> >><br>
>>> >> I agree with your opinion that BASE_XSTATIC_MODULES should not be<br>
>>> >> modified.<br>
>>> >> It is much better to enhance horizon plugin settings,<br>
>>> >> and I think maybe there could be one option like ADD_XSTATIC_MODULES.<br>
>>> >> This option adds the plugin's xstatic files in STATICFILES_DIRS.<br>
>>> >> I am considering to add a bug report to describe it at first, and give<br>
>>> >> a<br>
>>> >> patch later maybe.<br>
>>> >> Is that ok with the Horizon team?<br>
>>> >><br>
>>> >> Best Regards.<br>
>>> >> Xinni<br>
>>> >><br>
>>> >> On Fri, Mar 9, 2018 at 11:47 PM, Akihiro Motoki <<a href="mailto:amotoki@gmail.com">amotoki@gmail.com</a>><br>
>>> >> wrote:<br>
>>> >>><br>
>>> >>> Hi Xinni,<br>
>>> >>><br>
>>> >>> 2018-03-09 12:05 GMT+09:00 Xinni Ge <<a href="mailto:xinni.ge1990@gmail.com">xinni.ge1990@gmail.com</a>>:<br>
>>> >>> > Hello Horizon Team,<br>
>>> >>> ><br>
>>> >>> > I would like to hear about your opinions about how to add new<br>
>>> >>> > xstatic<br>
>>> >>> > modules to horizon settings.<br>
>>> >>> ><br>
>>> >>> > As for Heat-dashboard project embedded 3rd-party files issue,<br>
>>> >>> > thanks<br>
>>> >>> > for<br>
>>> >>> > your advices in Dublin PTG, we are now removing them and<br>
>>> >>> > referencing as<br>
>>> >>> > new<br>
>>> >>> > xstatic-* libs.<br>
>>> >>><br>
>>> >>> Thanks for moving this forward.<br>
>>> >>><br>
>>> >>> > So we installed the new xstatic files (not uploaded as openstack<br>
>>> >>> > official<br>
>>> >>> > repos yet) in our development environment now, but hesitate to<br>
>>> >>> > decide<br>
>>> >>> > how to<br>
>>> >>> > add the new installed xstatic lib path to STATICFILES_DIRS in<br>
>>> >>> > openstack_dashboard.settings so that the static files could be<br>
>>> >>> > automatically<br>
>>> >>> > collected by *collectstatic* process.<br>
>>> >>> ><br>
>>> >>> > Currently Horizon defines BASE_XSTATIC_MODULES in<br>
>>> >>> > openstack_dashboard/utils/<wbr>settings.py and the relevant static fils<br>
>>> >>> > are<br>
>>> >>> > added<br>
>>> >>> > to STATICFILES_DIRS before it updates any Horizon plugin dashboard.<br>
>>> >>> > We may want new plugin setting keywords ( something similar to<br>
>>> >>> > ADD_JS_FILES)<br>
>>> >>> > to update horizon XSTATIC_MODULES (or directly update<br>
>>> >>> > STATICFILES_DIRS).<br>
>>> >>><br>
>>> >>> IMHO it is better to allow horizon plugins to add xstatic modules<br>
>>> >>> through horizon plugin settings. I don't think it is a good idea to<br>
>>> >>> add a new entry in BASE_XSTATIC_MODULES based on horizon plugin<br>
>>> >>> usages. It makes difficult to track why and where a xstatic module in<br>
>>> >>> BASE_XSTATIC_MODULES is used.<br>
>>> >>> Multiple horizon plugins can add a same entry, so horizon code to<br>
>>> >>> handle plugin settings should merge multiple entries to a single one<br>
>>> >>> hopefully.<br>
>>> >>> My vote is to enhance the horizon plugin settings.<br>
>>> >>><br>
>>> >>> Akihiro<br>
>>> >>><br>
>>> >>> ><br>
>>> >>> > Looking forward to hearing any suggestions from you guys, and<br>
>>> >>> > Best Regards,<br>
>>> >>> ><br>
>>> >>> > Xinni Ge<br>
>>> >>> ><br>
>>> >>> ><br>
>>> >>> ><br>
>>> >>> > ______________________________<wbr>______________________________<wbr>______________<br>
>>> >>> > OpenStack Development Mailing List (not for usage questions)<br>
>>> >>> > Unsubscribe:<br>
>>> >>> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> >>> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>>> >>> ><br>
>>> >>><br>
>>> >>><br>
>>> >>><br>
>>> >>> ______________________________<wbr>______________________________<wbr>______________<br>
>>> >>> OpenStack Development Mailing List (not for usage questions)<br>
>>> >>> Unsubscribe:<br>
>>> >>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> >>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>>> >><br>
>>> >><br>
>>> >><br>
>>> >><br>
>>> >> --<br>
>>> >> 葛馨霓 Xinni Ge<br>
>>> >><br>
>>> >><br>
>>> >> ______________________________<wbr>______________________________<wbr>______________<br>
>>> >> OpenStack Development Mailing List (not for usage questions)<br>
>>> >> Unsubscribe:<br>
>>> >> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> >> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>>> >><br>
>>> ><br>
>>> ><br>
>>> ><br>
>>> > ______________________________<wbr>______________________________<wbr>______________<br>
>>> > OpenStack Development Mailing List (not for usage questions)<br>
>>> > Unsubscribe:<br>
>>> > <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> > <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>>> ><br>
>>><br>
>>><br>
>>> ______________________________<wbr>______________________________<wbr>______________<br>
>>> OpenStack Development Mailing List (not for usage questions)<br>
>>> Unsubscribe:<br>
>>> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>><br>
>><br>
>><br>
>> ______________________________<wbr>______________________________<wbr>______________<br>
>> OpenStack Development Mailing List (not for usage questions)<br>
>> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
>> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
>><br>
><br>
><br>
><br>
> --<br>
> 葛馨霓 Xinni Ge<br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</div></div></blockquote></div><br></div>