<div dir="ltr">Yes, please do that. We can then discuss in the review about technical details.</div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Mar 12, 2018 at 2:54 AM, Xinni Ge <span dir="ltr"><<a href="mailto:xinni.ge1990@gmail.com" target="_blank">xinni.ge1990@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi, Akihiro<div><br></div><div>Thanks for the quick reply.</div><div><br></div><div>I agree with your opinion that <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">BASE_XSTATIC_MODULES should not be modified.</span></div><div><span style="font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">It is much better to enhance horizon plugin settings,</span></div><div><span style="font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"> and I think maybe there could be one option like ADD_XSTATIC_MODULES.<br>This option adds the plugin's xstatic files in <span style="font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"><font color="#000000">STATICFILES_DIRS</font></span><span style="color:rgb(80,0,80);font-weight:400;font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">.</span></span></div><div><font color="#000000"><span style="font-size:12.8px">I am considering to add a bug report to describe it at first, and give a patch later maybe.</span></font></div><div><font color="#000000"><span style="font-size:12.8px">Is that ok with the Horizon team?</span></font></div><div><br></div><div>Best Regards.</div><div>Xinni</div></div><div class="gmail_extra"><div><div class="h5"><br><div class="gmail_quote">On Fri, Mar 9, 2018 at 11:47 PM, Akihiro Motoki <span dir="ltr"><<a href="mailto:amotoki@gmail.com" target="_blank">amotoki@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Xinni,<br>
<span><br>
2018-03-09 12:05 GMT+09:00 Xinni Ge <<a href="mailto:xinni.ge1990@gmail.com" target="_blank">xinni.ge1990@gmail.com</a>>:<br>
> Hello Horizon Team,<br>
><br>
> I would like to hear about your opinions about how to add new xstatic<br>
> modules to horizon settings.<br>
><br>
> As for Heat-dashboard project embedded 3rd-party files issue, thanks for<br>
> your advices in Dublin PTG, we are now removing them and referencing as new<br>
> xstatic-* libs.<br>
<br>
</span>Thanks for moving this forward.<br>
<span><br>
> So we installed the new xstatic files (not uploaded as openstack official<br>
> repos yet) in our development environment now, but hesitate to decide how to<br>
> add the new installed xstatic lib path to STATICFILES_DIRS in<br>
> openstack_dashboard.settings so that the static files could be automatically<br>
> collected by *collectstatic* process.<br>
><br>
> Currently Horizon defines BASE_XSTATIC_MODULES in<br>
> openstack_dashboard/utils/sett<wbr>ings.py and the relevant static fils are added<br>
> to STATICFILES_DIRS before it updates any Horizon plugin dashboard.<br>
> We may want new plugin setting keywords ( something similar to ADD_JS_FILES)<br>
> to update horizon XSTATIC_MODULES (or directly update STATICFILES_DIRS).<br>
<br>
</span>IMHO it is better to allow horizon plugins to add xstatic modules<br>
through horizon plugin settings. I don't think it is a good idea to<br>
add a new entry in BASE_XSTATIC_MODULES based on horizon plugin<br>
usages. It makes difficult to track why and where a xstatic module in<br>
BASE_XSTATIC_MODULES is used.<br>
Multiple horizon plugins can add a same entry, so horizon code to<br>
handle plugin settings should merge multiple entries to a single one<br>
hopefully.<br>
My vote is to enhance the horizon plugin settings.<br>
<br>
Akihiro<br>
<span><br>
><br>
> Looking forward to hearing any suggestions from you guys, and<br>
> Best Regards,<br>
><br>
> Xinni Ge<br>
><br>
</span>> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span class="HOEnZb"><font color="#888888">-- <br><div class="m_-440245623556261711gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div>葛馨霓 Xinni Ge</div></div></div></div></div></div>
</font></span></div>
<br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br></blockquote></div><br></div>