<div dir="ltr"><div class="gmail_default" style="font-family:monospace,monospace">Hi,</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">Thanks for all the reviews. Just one more + CI change and docs left now.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">**HEADs UP**: <br></div><div class="gmail_default" style="font-family:monospace,monospace">I think we might have broken ovb jobs until <a href="https://review.openstack.org/537830" rel="noreferrer" target="_blank">5<wbr>37830</a> is landed once packages are promoted. This is due to a change in Ironic[1] that I realized yesterday is not yet in the packages used by tripleo CI. We should make sure the Prep-CI patch below lands before we have packages promoted.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"><div class="gmail_default" style="font-family:monospace,monospace">* Prep-CI for routed-networks changes
</div><div class="gmail_default" style="font-family:monospace,monospace"> <a href="https://review.openstack.org/#/c/541678/" target="_blank">https://review.openstack.org/#<wbr>/c/541678/</a></div><br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">* Install and enable neutron baremetal mech plugin<br>
<a href="https://review.openstack.org/537830" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>37830<br></a></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">This needs a rebase, I will do it today.</div><div class="gmail_default" style="font-family:monospace,monospace">It also needs packages that is not available in repos used by CI.<br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">tripleo-docs<br>
------------<br>
<br>
* Documentation - TripleO routed-spine-and-leaf<br>
<a href="https://review.openstack.org/#/c/539939/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/539939/</a></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">I will go over this again today, but so far reviews are good.</div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">//</div><div class="gmail_default" style="font-family:monospace,monospace">Harald<br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace"><br></div><div class="gmail_default" style="font-family:monospace,monospace">[1] <a href="https://review.openstack.org/#/c/536040/">https://review.openstack.org/#/c/536040/</a><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 5, 2018 at 3:42 AM, Emilien Macchi <span dir="ltr"><<a href="mailto:emilien@redhat.com" target="_blank">emilien@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><br><div class="gmail_extra"><br><div class="gmail_quote"><div><div class="h5">On Fri, Feb 2, 2018 at 3:28 AM, Harald Jensås <span dir="ltr"><<a href="mailto:hjensas@redhat.com" target="_blank">hjensas@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Requesting: <br>
Feuture Freeze Exception request for Routed Spine and Leaf Deployment<br>
<br>
Blueprints:<br>
<a href="https://blueprints.launchpad.net/tripleo/+spec/tripleo-routed-networks-ironic-inspector" rel="noreferrer" target="_blank">https://blueprints.launchpad.n<wbr>et/tripleo/+spec/tripleo-route<wbr>d-networks-<br>
ironic-inspector</a><br>
<a href="https://blueprints.launchpad.net/tripleo/+spec/tripleo-routed-networks-" rel="noreferrer" target="_blank">https://blueprints.launchpad.n<wbr>et/tripleo/+spec/tripleo-route<wbr>d-networks-</a><br>
deployment<br>
<br>
All external dependencies for Routed Spine and Leaf Deployement have<br>
finally landed. (Except puppet module changes.)<br>
<br>
<br>
Pros<br>
====<br>
<br>
This delivers a feature that has been requested since the Kilo release.<br>
It makes TripleO more viable in large deployments as well as in edge<br>
use cases where openstack services are not deployed in one datacenter.<br>
<br>
The core piece in this is the neutron segments service_plugin. This has<br>
been around since newton. Most of the instack-undercloud patches were<br>
first proposed during ocata.<br>
<br>
The major change is in the undercloud. In tripleo-heat-templates we<br>
need just a small change to ensure we get ip addresses allocated from<br>
neutron when segments service plug-in is enabled in neutron. The<br>
overcloud configuration stays the same, we already do have users<br>
deploying routed networks in the isolated networks using composable<br>
networks so we know it works.<br>
<br>
<br>
Risks<br>
=====<br>
<br>
I see little risk introducing a regression to current functionality<br>
with these changes. The major part of the undercloud patches has been<br>
around for a long time and passing CI.<br>
<br>
The format of undercloud.conf is changed, options are deprecated and<br>
new options are added to enable multiple control plane subnets/l2-<br>
segments to be defined. All options are properly deprectated, so<br>
using a configuration file from pike will still work.<br>
<br>
<br>
<br>
==============================<wbr>=======<br>
The list of patches that need to land<br>
==============================<wbr>=======<br>
<br>
instack-undercloud<br>
------------------<br>
<br>
* Tripleo routed networks ironic inspector, and Undercloud<br>
<a href="https://review.openstack.org/#/c/437544/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/437544/</a><br>
* Move ctlplane network/subnet setup to python<br>
<a href="https://review.openstack.org/533364" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33364</a><br>
* Update config to use per network groups<br>
<a href="https://review.openstack.org/533365" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33365</a><br>
* Update validations to validate all subnets<br>
<a href="https://review.openstack.org/533366" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33366</a><br>
* Add support for multiple inspection subnets<br>
<a href="https://review.openstack.org/533367" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33367</a><br>
* Create static routes for remote subnets<br>
<a href="https://review.openstack.org/533368" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33368</a><br>
* Add per subnet network cidr nat rules<br>
<a href="https://review.openstack.org/533369" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33369</a><br>
* Add per subnet masquerading<br>
<a href="https://review.openstack.org/533370" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>33370</a><br>
* Install and enable neutron baremetal mech plugin<br>
<a href="https://review.openstack.org/537830" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>37830</a><br>
<br>
tripleo-heat-templates<br>
----------------------<br>
<br>
* Add subnet property to ctlplane network for server resources<br>
<a href="https://review.openstack.org/473817" rel="noreferrer" target="_blank">https://review.openstack.org/4<wbr>73817</a> <br>
<br>
tripleo-docs<br>
------------<br>
<br>
* Documentation - TripleO routed-spine-and-leaf<br>
<a href="https://review.openstack.org/#/c/539939/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/539939/</a> <br>
<br>
puppet-neutron<br>
--------------<br>
<br>
* Add networking-baremetal ml2 plug-in<br>
<a href="https://review.openstack.org/537826" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>37826</a> <br>
* Add networking-baremetal - ironic-neutron-agent<br>
<a href="https://review.openstack.org/539405" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>39405</a><br>
<span class="m_3436295622500792323gmail-HOEnZb"><font color="#888888"><br></font></span></blockquote><div><br></div></div></div><div>I'm a bit concerned by the delay of this request. Feature freeze request deadline was 10 days ago:</div><div><a href="https://releases.openstack.org/queens/schedule.html#q-ff" target="_blank">https://releases.openstack.<wbr>org/queens/schedule.html#q-ff</a></div><div><br></div><div>We're now in the process on producing a release candidate. The amount of code that needs to land to have the feature completed isn't small but it looks like well tested and you seems pretty confident.</div></div>I'm not sure what to vote on this one tbh because yeah the use-case is super important, and we know how Queens release is important to us. But at the same time there is a risk to introduce problems, and delay the potentially delay the release and after the delivery of other features...</div><div class="gmail_extra"><br></div><div class="gmail_extra">I guess I'm ok as long as all patches pass ALL CI jobs without exception and are carefully tested and reviewed.</div><div class="gmail_extra"><br>Thanks,</div><span class="HOEnZb"><font color="#888888"><div class="gmail_extra">-- <br><div class="m_3436295622500792323gmail_signature"><div dir="ltr">Emilien Macchi<br></div></div>
</div></font></span></div>
</blockquote></div><br><br clear="all"><br>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><span style="font-family:monospace,monospace">|Harald Jensås | Cloud Success Architect<br>|<a href="mailto:hjensas@redhat.com" target="_blank">hjensas@redhat.com</a> | <a href="http://www.redhat.com" target="_blank">www.redhat.com</a><br>|+46 (0)701 91 23 17 | hjensas:irc</span><br></div></div>
</div></div>