<div dir="ltr"><div><div><div><div><div>I have updated the bug with info I found out: <a href="https://bugs.launchpad.net/oslo.serialization/+bug/1728368">https://bugs.launchpad.net/oslo.serialization/+bug/1728368</a><br><br></div>Also I did a test patch with a proposed change:<br><a href="https://review.openstack.org/#/c/535166/">https://review.openstack.org/#/c/535166/</a><br><br></div>This patch causes the unit tests to work.<br><br>As a note there is a deprecation warning in the current code (without my patch) that says in the future it will raise a ValueError() as can be seen in a recently merged patch:<br><a href="http://logs.openstack.org/72/533872/6/check/openstack-tox-py27/4709e32/job-output.txt.gz#_2018-01-16_13_10_38_931593">http://logs.openstack.org/72/533872/6/check/openstack-tox-py27/4709e32/job-output.txt.gz#_2018-01-16_13_10_38_931593</a><br><br></div>The test patch gets rid of that deprecation warning for the exceptions.<br><br></div>Though I did see another warning about the "Response" object:<br><a href="http://logs.openstack.org/66/535166/2/check/openstack-tox-py35/33d0827/job-output.txt.gz#_2018-01-18_05_13_52_603162">http://logs.openstack.org/66/535166/2/check/openstack-tox-py35/33d0827/job-output.txt.gz#_2018-01-18_05_13_52_603162</a><br><br></div>But that is for someone else to figure out :)<br><div><div><div><br><br></div></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Jan 17, 2018 at 7:13 PM, ChangBo Guo <span dir="ltr"><<a href="mailto:glongwave@gmail.com" target="_blank">glongwave@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div>add Ironic team  in the loop<br><br></div>the revert patch got -1 from  ironic folks , more details  please see the comments in <span class="m_-53466578340697793gmail-m_-6331875189824115667gmail-im"><a href="https://review.openstack.org/534736" target="_blank">https://review.openstack.org/5<wbr>34736</a><br></span></div><span class="m_-53466578340697793gmail-m_-6331875189824115667gmail-im">The possible solution is to figure out why  the change break Glance's unit test.  which side should be fixed.  </span><br><div><div><span class="m_-53466578340697793gmail-m_-6331875189824115667gmail-im"></span><div><br><br><div><div class="gmail_extra"><br><div class="gmail_quote">2018-01-17 20:14 GMT+08:00 ChangBo Guo <span dir="ltr"><<a href="mailto:glongwave@gmail.com" target="_blank">glongwave@gmail.com</a>></span>:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><div dir="ltr"><div>I dig a little.  It shows success when updating constraint to 2.21.2 [1] but  failure when updating constraint to 2.22.0 [2].   according to release information [3].<br></div><div>It means 2.21.1 works with glance test but  2.21.2 doesn't work well with glance. The only issue patch <span class="m_-53466578340697793gmail-m_-6331875189824115667gmail-im">is <a href="https://github.com/openstack/oslo.serialization/commit/c1a7079c26d27a2e46cca26963d3d9aa040bdbe8" target="_blank">https://github.com/openstack/o<wbr>slo.serialization/commit/c1a70<wbr>79c26d27a2e46cca26963d3d9aa040<wbr>bdbe8</a>.<br>    <br></span></div><div><br>[1] <a href="https://review.openstack.org/514833" target="_blank">https://review.openstack.org/5<wbr>14833</a><br>[2] <a href="https://review.openstack.org/#/c/525136" target="_blank">https://review.openstack.org/#<wbr>/c/525136</a><br>[3] <a href="https://github.com/openstack/releases/blob/master/deliverables/queens/oslo.serialization.yaml" target="_blank">https://github.com/openstack/r<wbr>eleases/blob/master/deliverabl<wbr>es/queens/oslo.serialization.<wbr>yaml</a><br><br><br></div><div>Actions:<br><br></div><div>Block  oslo.serialization  version  2.21.2,  2.22.0, 2. 23.0    in  <a href="https://review.openstack.org/534739" target="_blank">https://review.openstack.org/5<wbr>34739</a><br></div><div>Revert <span class="m_-53466578340697793gmail-m_-6331875189824115667gmail-im">c1a7079c26d27a2e46cca26963d3d9<wbr>aa040bdbe8 in <a href="https://review.openstack.org/534736" target="_blank">https://review.openstack.org/5<wbr>34736</a><br></span><br><br><br></div></div><div class="gmail_extra"><div><div class="h5"><div><div class="m_-53466578340697793gmail-h5"><br><div class="gmail_quote">2018-01-16 23:35 GMT+08:00 Matthew Thode <span dir="ltr"><<a href="mailto:prometheanfire@gentoo.org" target="_blank">prometheanfire@gentoo.org</a>></span>:<br><blockquote style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex" class="gmail_quote"><span>On 18-01-16 19:12:16, ChangBo Guo wrote:<br>
> What's the issue for Glance,  any bug link ?<br>
><br>
> 2018-01-16 0:12 GMT+08:00 Matthew Thode <<a href="mailto:prometheanfire@gentoo.org" target="_blank">prometheanfire@gentoo.org</a>>:<br>
><br>
> > On 18-01-13 00:41:28, Matthew Thode wrote:<br>
> > > <a rel="noreferrer" href="https://review.openstack.org/531788" target="_blank">https://review.openstack.org/5<wbr>31788</a> is the review we are seeing it in,<br>
> > > but 2.22.0 failed as well.<br>
> > ><br>
> > > I'm guessing it was introduced in either<br>
> > ><br>
> > > <a rel="noreferrer" href="https://github.com/openstack/oslo.serialization/commit/" target="_blank">https://github.com/openstack/o<wbr>slo.serialization/commit/</a><br>
> > c1a7079c26d27a2e46cca26963d3d9<wbr>aa040bdbe8<br>
> > > or<br>
> > > <a rel="noreferrer" href="https://github.com/openstack/oslo.serialization/commit/" target="_blank">https://github.com/openstack/o<wbr>slo.serialization/commit/</a><br>
> > cdb2f60d26e3b65b6370f87b2e9864<wbr>045651c117<br>
> ><br>
> > bamp<br>
> ><br>
<br>
</span>The best bug for this is<br>
<a rel="noreferrer" href="https://bugs.launchpad.net/oslo.serialization/+bug/1728368" target="_blank">https://bugs.launchpad.net/osl<wbr>o.serialization/+bug/1728368</a> and we are<br>
currently getting test fails in <a rel="noreferrer" href="https://review.openstack.org/531788" target="_blank">https://review.openstack.org/5<wbr>31788</a><br>
<span class="m_-53466578340697793gmail-m_-6331875189824115667HOEnZb"><font color="#888888"><br>
--<br>
Matthew Thode (prometheanfire)<br>
</font></span></blockquote></div><br><br clear="all"><br></div></div></div></div><span class=""><span class="m_-53466578340697793gmail-">-- <br><div class="m_-53466578340697793gmail-m_-6331875189824115667gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>ChangBo Guo(gcb)<br></div><div>Community Director @EasyStack<br></div></div></div></div></div>
</span></span></div>
</blockquote></div><span class=""><br><br clear="all"><br>-- <br><div class="m_-53466578340697793gmail_signature"><div dir="ltr"><div><div dir="ltr"><div>ChangBo Guo(gcb)<br></div><div>Community Director @EasyStack<br></div></div></div></div></div>
</span></div></div></div></div></div></div>
<br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
<br></blockquote></div><br></div>