<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Jan 10, 2018 at 11:24 AM, Sriharsha Basavapatna <span dir="ltr"><<a href="mailto:sriharsha.basavapatna@broadcom.com" target="_blank">sriharsha.basavapatna@broadcom.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On Tue, Jan 9, 2018 at 10:46 PM, Stephen Finucane <<a href="mailto:sfinucan@redhat.com">sfinucan@redhat.com</a>> wrote:<br>
> On Tue, 2018-01-09 at 16:30 +0530, Sriharsha Basavapatna wrote:<br>
>> On Tue, Jan 9, 2018 at 2:20 PM, Sriharsha Basavapatna<br>
>> <<a href="mailto:sriharsha.basavapatna@broadcom.com">sriharsha.basavapatna@<wbr>broadcom.com</a>> wrote:<br>
>> > Hi Andreas,<br>
>> ><br>
>> > On Tue, Jan 9, 2018 at 12:04 PM, Andreas Jaeger <<a href="mailto:aj@suse.com">aj@suse.com</a>><br>
>> > wrote:<br>
>> > > On 2018-01-09 07:00, Sriharsha Basavapatna wrote:<br>
>> > > > Hi,<br>
>> > > ><br>
>> > > > I've uploaded a patch for review:<br>
>> > > > <a href="https://review.openstack.org/#/c/531674/" rel="noreferrer" target="_blank">https://review.openstack.org/#<wbr>/c/531674/</a><br>
>> > > ><br>
>> > > > This is the first time I'm submitting a patch on openstack. I'd<br>
>> > > > like<br>
>> > ><br>
>> > > Welcome to OpenStack, Harsha.<br>
>> ><br>
>> > Thank you.<br>
>> ><br>
>> > > Please read<br>
>> > > <a href="https://docs.openstack.org/infra/manual/developers.html" rel="noreferrer" target="_blank">https://docs.openstack.org/<wbr>infra/manual/developers.html</a> if you<br>
>> > > haven't.<br>
>> ><br>
>> > Ok, i'll read it.<br>
>> > ><br>
>> > > I see that your change fails the basic tests, you can run these<br>
>> > > locally<br>
>> > > as follows to check that your fixes will pass:<br>
>> > ><br>
>> > > tox -e pep8<br>
>> > > tox -e py27<br>
>> ><br>
>> > I was wondering if there's a way to catch these errors without<br>
>> > having<br>
>> > to submit it for gerrit review.  I fixed the ones that were<br>
>> > reported<br>
>> > in patch-set-1; looks like there's some new ones in the second<br>
>> > patch-set. I'll run the above commands to verify the fix locally.<br>
>> ><br>
>> > Thanks,<br>
>> > -Harsha<br>
>><br>
>> I installed python-pip and tox.  But when I run "tox -e pep8", I'm<br>
>> seeing some errors:<br>
>><br>
>>     building 'netifaces' extension<br>
>>     gcc -pthread -fno-strict-aliasing -O2 -g -pipe -Wall<br>
>> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong<br>
>> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic<br>
>> -D_GNU_SOURCE -fPIC -fwrapv -DNDEBUG -O2 -g -pipe -Wall<br>
>> -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong<br>
>> --param=ssp-buffer-size=4 -grecord-gcc-switches -m64 -mtune=generic<br>
>> -D_GNU_SOURCE -fPIC -fwrapv -fPIC -DNETIFACES_VERSION=0.10.6<br>
>> -DHAVE_GETIFADDRS=1 -DHAVE_GETNAMEINFO=1 -DHAVE_NETASH_ASH_H=1<br>
>> -DHAVE_NETATALK_AT_H=1 -DHAVE_NETAX25_AX25_H=1<br>
>> -DHAVE_NETECONET_EC_H=1<br>
>> -DHAVE_NETIPX_IPX_H=1 -DHAVE_NETPACKET_PACKET_H=1<br>
>> -DHAVE_LINUX_IRDA_H=1 -DHAVE_LINUX_ATM_H=1 -DHAVE_LINUX_LLC_H=1<br>
>> -DHAVE_LINUX_TIPC_H=1 -DHAVE_LINUX_DN_H=1 -DHAVE_SOCKADDR_AT=1<br>
>> -DHAVE_SOCKADDR_AX25=1 -DHAVE_SOCKADDR_IN=1 -DHAVE_SOCKADDR_IN6=1<br>
>> -DHAVE_SOCKADDR_IPX=1 -DHAVE_SOCKADDR_UN=1 -DHAVE_SOCKADDR_ASH=1<br>
>> -DHAVE_SOCKADDR_EC=1 -DHAVE_SOCKADDR_LL=1 -DHAVE_SOCKADDR_ATMPVC=1<br>
>> -DHAVE_SOCKADDR_ATMSVC=1 -DHAVE_SOCKADDR_DN=1 -DHAVE_SOCKADDR_IRDA=1<br>
>> -DHAVE_SOCKADDR_LLC=1 -DHAVE_PF_NETLINK=1 -I/usr/include/python2.7 -c<br>
>> netifaces.c -o build/temp.linux-x86_64-2.7/<wbr>netifaces.o<br>
>>     netifaces.c:1:20: fatal error: Python.h: No such file or<br>
>> directory<br>
>>      #include <Python.h><br>
>>                         ^<br>
>>     compilation terminated.<br>
>>     error: command 'gcc' failed with exit status 1<br>
>><br>
>>     ------------------------------<wbr>----------<br>
>> Command "/home/harshab/os-vif/.tox/<wbr>pep8/bin/python2 -u -c "import<br>
>> setuptools, tokenize;__file__='/tmp/pip-<wbr>build-<br>
>> OibnHO/netifaces/setup.py';f=<wbr>getattr(tokenize,<br>
>> 'open', open)(__file__);code=f.read().<wbr>replace('\r\n',<br>
>> '\n');f.close();exec(compile(<wbr>code, __file__, 'exec'))" install<br>
>> --record /tmp/pip-3Hu__1-record/<wbr>install-record.txt<br>
>> --single-version-externally-<wbr>managed --compile --install-headers<br>
>> /home/harshab/os-vif/.tox/<wbr>pep8/include/site/python2.7/<wbr>netifaces"<br>
>> failed with error code 1 in /tmp/pip-build-OibnHO/<wbr>netifaces/<br>
>><br>
>> ERROR: could not install deps<br>
>> [-r/home/harshab/os-vif/<wbr>requirements.txt,<br>
>> -r/home/harshab/os-vif/test-<wbr>requirements.txt]; v =<br>
>> InvocationError('/home/<wbr>harshab/os-vif/.tox/pep8/bin/<wbr>pip install -U<br>
>> -r/home/harshab/os-vif/<wbr>requirements.txt<br>
>> -r/home/harshab/os-vif/test-<wbr>requirements.txt (see<br>
>> /home/harshab/os-vif/.tox/<wbr>pep8/log/pep8-1.log)', 1)<br>
>> ______________________________<wbr>_____ summary<br>
>> ______________________________<wbr>______<br>
>> ERROR:   pep8: could not install deps<br>
>> [-r/home/harshab/os-vif/<wbr>requirements.txt,<br>
>> -r/home/harshab/os-vif/test-<wbr>requirements.txt]; v =<br>
>> InvocationError('/home/<wbr>harshab/os-vif/.tox/pep8/bin/<wbr>pip install -U<br>
>> -r/home/harshab/os-vif/<wbr>requirements.txt<br>
>> -r/home/harshab/os-vif/test-<wbr>requirements.txt (see<br>
>> /home/harshab/os-vif/.tox/<wbr>pep8/log/pep8-1.log)', 1)<br>
>><br>
>> Thanks,<br>
>> -Harsha<br>
><br>
> That's happening because the 'pep8' target is installing all the<br>
> requirements for the project in a virtualenv, and one of them needs<br>
> Python development headers. What Linux distro are you using? On Fedora<br>
> you can fix this like so:<br>
><br>
>     sudo dnf install python-devel<br>
<br>
Thanks Stephen, I'm using RHEL and 'yum install python-devel' resolved it.<br>
-Harsha<br>
<br></blockquote><div><br></div><div>I've resolved the test errors and addressed code review comments.  The updated patch for review is here: <a href="https://review.openstack.org/#/c/531674/">https://review.openstack.org/#/c/531674/</a></div><div><br></div><div>legacy-tempest-dsvm-nova-os-vif is reporting an error; but I'm not sure if this is related to the changes in this patch-set since I couldn't find any relevant errors in the log files.</div><div><br></div><div>Zuul has reported 'Verified+1' on this patch.</div><div><br></div><div>Thanks,</div><div>-Harsha</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
><br>
> On Ubuntu, I think it's something like this:<br>
><br>
>     sudo apt-get install python-dev<br>
><br>
> Stephen<br>
><br>
> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</blockquote></div><br></div></div>