<div dir="ltr"><div dir="auto"><font face="monospace, monospace">yes. it is not <div class="gmail_default" style="font-size:small;display:inline">recommend to use in prod env, i never used this script. But </div></font></div><div dir="auto"><font face="monospace, monospace"><div class="gmail_default" style="font-size:small;display:inline">the reality is </div></font><span style="font-family:monospace,monospace">lots users are using it, at least in the test environment.</span></div><div dir="auto"><font face="monospace, monospace"><div class="gmail_default" style="font-size:small;display:inline">and there are patches trying to make this script </div><span style="font-size:12.8px">idempotent<div class="gmail_default" style="font-family:monospace,monospace;font-size:small;display:inline"> recently.</div></span></font></div><div class="gmail_extra"><br><div class="gmail_quote">2017年11月28日 23:28，"Sam Yaple" <<a href="mailto:sam@yaple.net" target="_blank">sam@yaple.net</a>>写道：<br type="attribution"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>For what its worth, this init-runonce script was never meant for production usage. Ops *shouldn't* be running it like you suggest. It was historically for use in the gate and a quick-n-dirty environment setup for testing.<br></div><div><br></div><div>If you want to get into writing operations scripts, thats your prerogative, but it was discussed before and mostly considered a bad idea.<br></div><div><br></div><div>Thanks,<br></div><div>SamYaple<br></div><div class="gmail-m_8803862222613683673m_7405315328385846847protonmail_signature_block gmail-m_8803862222613683673m_7405315328385846847protonmail_signature_block-empty"><div class="gmail-m_8803862222613683673m_7405315328385846847protonmail_signature_block-user gmail-m_8803862222613683673m_7405315328385846847protonmail_signature_block-empty"><br></div><div class="gmail-m_8803862222613683673m_7405315328385846847protonmail_signature_block-proton gmail-m_8803862222613683673m_7405315328385846847protonmail_signature_block-empty"><br></div></div><div><br></div><blockquote type="cite" class="gmail-m_8803862222613683673m_7405315328385846847protonmail_quote"><div>-------- Original Message --------<br></div><div>Subject: Re: [openstack-dev] [kolla] Ansiblize init-runonce script<br></div><div>Local Time: November 28, 2017 8:10 AM<br></div><div>UTC Time: November 28, 2017 1:10 PM<br></div><div>From: <a href="mailto:zhang.lei.fly@gmail.com" target="_blank">zhang.lei.fly@gmail.com</a><br></div><div>To: OpenStack Development Mailing List (not for usage questions) <<a href="mailto:openstack-dev@lists.openstack.org" target="_blank">openstack-dev@lists.openstack<wbr>.org</a>><br></div><div><br></div><div dir="ltr"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font"><div>in my opinion, <br></div><div class="gmail_default" style="font-size:small;display:inline"><br></div><div class="gmail_default" style="display:inline"><br></div><div>idempotent scrip<br></div><div class="gmail_default" style="font-size:small;display:inline">t is very necessary.<br></div></span><div><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font">for several reason</span><br></div></div><div><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font"></span><br></div></div><div><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font">- there is already some idempotent logical in the script</span><br></div></div><div><div class="gmail_default" style="font-size:small;display:inline"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font">- it is common that this script failed by wrong configuration, </span><br></div></div><div><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font"><div class="gmail_default" style="font-size:small;display:inline"> after fix the config,<br></div><div>ops will want to run this script again.<br></div></span></div></div><div class="gmail_extra"><div><br></div><div class="gmail_quote"><div>On Tue, Nov 28, 2017 at 7:14 PM, Paul Bourke <span dir="ltr"><<a href="mailto:paul.bourke@oracle.com" target="_blank">paul.bourke@oracle.com</a>></span> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div>I think this came up before at one stage. My position is I don't see the need to ansible-ise small shell scripts. init-runonce is currently just an easy to understand sequence of openstack commands provided to help people test/demo their setups. Unless we want to make it more than that, i.e. make it idempotent, customizable, etc. I don't see the need to wheel in Ansible.<span><br> <br> On 28/11/17 03:23, Jeffrey Zhang wrote:<br> </span></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><span>hi<br> <br> check this [0]. I tried to convert it to ansible playbooks.<br> <br> [0] <a href="https://review.openstack.org/523072" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>23072</a><br> <br></span><span> On Tue, Nov 28, 2017 at 2:57 AM, Ravi Shekhar Jethani <<a href="mailto:rsjethani@gmail.com" target="_blank">rsjethani@gmail.com</a> <mailto:<a href="mailto:rsjethani@gmail.com" target="_blank">rsjethani@gmail.com</a>>> wrote:<br> <br> Hi,<br> <br> While exploring kolla-ansible I ran into a few issues with<br> init-runonce script. This lead to following bugs and patches:<br> <br></span> <a href="https://launchpad.net/bugs/1732963" rel="noreferrer" target="_blank">https://launchpad.net/bugs/173<wbr>2963</a> <<a href="https://launchpad.net/bugs/1732963" rel="noreferrer" target="_blank">https://launchpad.net/bugs/17<wbr>32963</a>></div><div> <a href="https://review.openstack.org/522221" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>22221</a><br></div><div> <<a href="https://review.openstack.org/522221" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>522221</a>><br></div><div> <a href="https://review.openstack.org/521190" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>21190</a><span><br> <<a href="https://review.openstack.org/521190" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>521190</a>><br> <br> But it was highlighted that instead of fixing/changing the<br> script, 'ansibilzing' it would be the ideal solution.<br> Hence I hereby formally propose the same.<br> <br> My thoughts:<br> * Playbook Name: init-stack.yml<br> <br> * Playbook path can be:<br> kolla-ansible/ansible/init-sta<wbr>ck.yml<br> <br> * The play can be executed like:<br> $ kolla-ansible init-stack -i <inventory_file><br> <br> * The cirros test image should be downloaded in /tmp<br> <br> * What should be the behavior if the play is run multiple times<br> against the same stack?<br> - some error message OR<br> - simply ignore the action<br> <br> Kindly provide suggestions.<br> <br> --<br> Best Regards,<br> Ravi J.<br> <br> ______________________________<wbr>______________________________<wbr>______________<br> OpenStack Development Mailing List (not for usage questions)<br> Unsubscribe:<br> <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br></span> <<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@<wbr>lists.openstack.org?subject:un<wbr>subscribe</a>></div><div> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><span><br> <<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cg<wbr>i-bin/mailman/listinfo/opensta<wbr>ck-dev</a>><br> <br> <br> <br> <br> -- <br> Regards,<br> Jeffrey Zhang<br></span> Blog: <a href="http://xcodest.me" rel="noreferrer" target="_blank">http://xcodest.me</a> <<a href="http://xcodest.me/" rel="noreferrer" target="_blank">http://xcodest.me/</a>><span><br> <br> <br> ______________________________<wbr>______________________________<wbr>______________<br> OpenStack Development Mailing List (not for usage questions)<br> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br> </span></div></blockquote><div class="gmail-m_8803862222613683673m_7405315328385846847HOEnZb"><div class="gmail-m_8803862222613683673m_7405315328385846847h5"><div><br></div><div>______________________________<wbr>______________________________<wbr>______________<br></div><div> OpenStack Development Mailing List (not for usage questions)<br></div><div> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br></div><div> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br></div></div></div></blockquote></div><div><br></div><div><br></div><div><br></div><div>-- <br></div><div class="gmail-m_8803862222613683673m_7405315328385846847gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px" class="gmail-m_8803862222613683673m_7405315328385846847size"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font">Regards,</span></span><br></div><div><span style="font-size:13px" class="gmail-m_8803862222613683673m_7405315328385846847size"><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font">Jeffrey Zhang</span></span><br></div><div><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font"><span style="font-size:12.8px" class="gmail-m_8803862222613683673m_7405315328385846847size">Blog: </span></span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><span style="font-family:monospace,monospace" class="gmail-m_8803862222613683673m_7405315328385846847font"></span><br></div></div></div></div></div></div></div></div></div></div></blockquote><div><br></div><br>______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br></blockquote></div></div>
</div>