<div dir="ltr"><font face="monospace, monospace">in my opinion, <div class="gmail_default" style="font-size:small;display:inline"></div><div class="gmail_default" style="display:inline"></div>idempotent scrip<div class="gmail_default" style="font-size:small;display:inline">t is very necessary.</div></font><div><div class="gmail_default" style="font-size:small;display:inline"><font face="monospace, monospace">for several reason</font></div></div><div><div class="gmail_default" style="font-size:small;display:inline"><font face="monospace, monospace"><br></font></div></div><div><div class="gmail_default" style="font-size:small;display:inline"><font face="monospace, monospace">- there is already some idempotent logical in the script</font></div></div><div><div class="gmail_default" style="font-size:small;display:inline"><font face="monospace, monospace">- it is common that this script failed by wrong configuration, </font></div></div><div><font face="monospace, monospace"><div class="gmail_default" style="font-size:small;display:inline"> after fix the config, </div>ops will want to run this script again.</font></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Nov 28, 2017 at 7:14 PM, Paul Bourke <span dir="ltr"><<a href="mailto:paul.bourke@oracle.com" target="_blank">paul.bourke@oracle.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I think this came up before at one stage. My position is I don't see the need to ansible-ise small shell scripts. init-runonce is currently just an easy to understand sequence of openstack commands provided to help people test/demo their setups. Unless we want to make it more than that, i.e. make it idempotent, customizable, etc. I don't see the need to wheel in Ansible.<span class=""><br>
<br>
On 28/11/17 03:23, Jeffrey Zhang wrote:<br>
</span><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
hi<br>
<br>
check this [0]. I tried to convert it to ansible playbooks.<br>
<br>
[0] <a href="https://review.openstack.org/523072" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>23072</a><br>
<br></span><span class="">
On Tue, Nov 28, 2017 at 2:57 AM, Ravi Shekhar Jethani <<a href="mailto:rsjethani@gmail.com" target="_blank">rsjethani@gmail.com</a> <mailto:<a href="mailto:rsjethani@gmail.com" target="_blank">rsjethani@gmail.com</a>>> wrote:<br>
<br>
Hi,<br>
<br>
While exploring kolla-ansible I ran into a few issues with<br>
init-runonce script. This lead to following bugs and patches:<br>
<br></span>
<a href="https://launchpad.net/bugs/1732963" rel="noreferrer" target="_blank">https://launchpad.net/bugs/173<wbr>2963</a> <<a href="https://launchpad.net/bugs/1732963" rel="noreferrer" target="_blank">https://launchpad.net/bugs/17<wbr>32963</a>><br>
<a href="https://review.openstack.org/522221" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>22221</a><br>
<<a href="https://review.openstack.org/522221" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>522221</a>><br>
<a href="https://review.openstack.org/521190" rel="noreferrer" target="_blank">https://review.openstack.org/5<wbr>21190</a><span class=""><br>
<<a href="https://review.openstack.org/521190" rel="noreferrer" target="_blank">https://review.openstack.org/<wbr>521190</a>><br>
<br>
But it was highlighted that instead of fixing/changing the<br>
script, 'ansibilzing' it would be the ideal solution.<br>
Hence I hereby formally propose the same.<br>
<br>
My thoughts:<br>
* Playbook Name: init-stack.yml<br>
<br>
* Playbook path can be:<br>
kolla-ansible/ansible/init-sta<wbr>ck.yml<br>
<br>
* The play can be executed like:<br>
$ kolla-ansible init-stack -i <inventory_file><br>
<br>
* The cirros test image should be downloaded in /tmp<br>
<br>
* What should be the behavior if the play is run multiple times<br>
against the same stack?<br>
- some error message OR<br>
- simply ignore the action<br>
<br>
Kindly provide suggestions.<br>
<br>
--<br>
Best Regards,<br>
Ravi J.<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe:<br>
<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br></span>
<<a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">http://OpenStack-dev-request@<wbr>lists.openstack.org?subject:un<wbr>subscribe</a>><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><span class=""><br>
<<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cg<wbr>i-bin/mailman/listinfo/opensta<wbr>ck-dev</a>><br>
<br>
<br>
<br>
<br>
-- <br>
Regards,<br>
Jeffrey Zhang<br></span>
Blog: <a href="http://xcodest.me" rel="noreferrer" target="_blank">http://xcodest.me</a> <<a href="http://xcodest.me/" rel="noreferrer" target="_blank">http://xcodest.me/</a>><span class=""><br>
<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
</span></blockquote><div class="HOEnZb"><div class="h5">
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></div></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><div dir="ltr"><div><div dir="ltr"><div dir="ltr"><div dir="ltr"><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Regards,</font></span></div><div><span style="font-size:13px;border-collapse:collapse"><font face="monospace, monospace">Jeffrey Zhang</font></span></div><div><span style="font-family:monospace,monospace;font-size:12.8px">Blog: </span><a href="http://xcodest.me/" style="font-family:monospace,monospace;font-size:12.8px" target="_blank">http://xcodest.me</a><font face="monospace, monospace"><br></font></div></div></div></div></div></div></div></div></div>
</div>