<div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On Sep 22, 2017 07:59, "Matt Riedemann" <<a href="mailto:mriedemos@gmail.com">mriedemos@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text">On 9/22/2017 9:50 AM, Rajath Agasthya (rajagast) wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
On 9/21/17, 10:19 PM, "Jeremy Freudberg" <<a href="mailto:jeremyfreudberg@gmail.com" target="_blank">jeremyfreudberg@gmail.com</a>> wrote:<br>
<br>
3) Delay spin-up of resource-intensive/long-runnin<wbr>g CI jobs until after some<br>
initial review has been added or time has passed. Authorized<br>
contributors, not necessarily synonymous with cores, can override the<br>
delay if there's a critical patch which needs to get through the queue<br>
quickly.<br>
+1. This is done in Go code review process, where CI is run by an explicit Run-TryBot+1<br>
review only after a core developer ascertains that the patch looks okay and most code<br>
review comments are addressed. This means no CI resource usage for every change and<br>
every single patchset. We could adopt a similar approach so that CI resources aren’t wasted<br>
for useless patches. This doesn’t take a whole lot of work for the reviewers than the current<br>
review process.<br>
<br>
<a href="https://github.com/golang/go/wiki/GerritAccess#trybot-access-may-start-trybots" rel="noreferrer" target="_blank">https://github.com/golang/go/w<wbr>iki/GerritAccess#trybot-access<wbr>-may-start-trybots</a><br>
<br>
Thanks,<br>
Rajath<br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
<br>
</blockquote>
<br></div>
Figuring out what is useless or not is probably not worth the effort here. We already skip long running tempest dsvm jobs in certain patches, like with docs or unit test only changes. Updating a code comment in code isn't going to catch that.<br>
<br>
And it's perfectly valid to have useful single-line code changes (although if it's a bug there should be a test too). Or multi-line changes that are just adding comments to code.<br>
<br>
Plus most people are probably not going to review something until CI has voted on it anyway, at least when you have the number of open reviews that some projects, like nova, has.<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">I agree. Reviewers already have a bunch of responsibilities on their plate and this would be another one. I also imagine it would be tough to get used to the absence of automatic testing after the default behavior for so long. </div><div dir="auto"><br></div><div dir="auto">I'd personally opt to look for these types of patches instead of losing automatic testing when patches are pushed. </div><div dir="auto"><br></div><div dir="auto"><div class="gmail_extra"><div class="gmail_quote"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
So I think this is a non-starter.<font color="#888888"><br>
<br>
-- <br>
<br>
Thanks,<br>
<br>
Matt</font><div class="elided-text"><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.op<wbr>enstack.org?subject:unsubscrib<wbr>e</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/cgi<wbr>-bin/mailman/listinfo/openstac<wbr>k-dev</a><br>
</div></blockquote></div><br></div></div></div>