<div dir="ltr">Dims, I'm not sure that's actually possible though. Many of these files have been through rewrites and developed over a large number of years. Listing all authors isn't practical.<div><br></div><div>Given the horse has bolted on forking these files, I feel like a comment acknowledging the original source file is probably sufficient.</div><div><br></div><div>What is concerning to me is that some of these files are part of the "ABI" of nova, and if mogan diverges from that then I think we're going to see user complaints in the future. Specifically configdrive, and metadata seem like examples of this. I don't want to see us end up in another "managed cut and paste" like early oslo where nova continues to develop these and mogan doesn't notice the changes.</div><div><br></div><div>I'm not sure how we resolve that. One option would be to refactor these files into a shared library.</div><div><br></div><div>Michael</div><div><br></div><div><br></div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Sep 20, 2017 at 5:51 AM, Davanum Srinivas <span dir="ltr"><<a href="mailto:davanum@gmail.com" target="_blank">davanum@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Zhenguo,<br>
<br>
Thanks for bringing this up.<br>
<br>
For #1, yes please indicate which file from Nova, so if anyone wanted<br>
to cross check for fixes etc can go look in Nova<br>
For #2, When you pick up a commit from Nova, please make sure the<br>
commit message in Mogan has the following<br>
   * The gerrit change id(s) of the original commit, so folks can<br>
easily go find the original commit in gerritt<br>
   * Add "Co-Authored-By:" tags for each author in the original commit<br>
so they get credit<br>
<br>
Also, Please make sure you do not alter any copyright or license<br>
related information in the header when you first copy a file from<br>
another project.<br>
<br>
Thanks,<br>
Dims<br>
<div><div class="h5"><br>
On Wed, Sep 20, 2017 at 4:20 AM, Zhenguo Niu <<a href="mailto:niu.zglinux@gmail.com">niu.zglinux@gmail.com</a>> wrote:<br>
> Hi all,<br>
><br>
> I'm from Mogan team, we copied some codes/frameworks from Nova since we want<br>
> to be a Nova with a bare metal specific API.<br>
> About why reinventing the wheel, you can find more informations here [1].<br>
><br>
> I would like to know what's the decent way to show our respect to the<br>
> original authors we copied from.<br>
><br>
> After discussing with the team, we plan to do some improvements as below:<br>
><br>
> 1. Adds some comments to the beginning of such files to indicate that they<br>
> leveraged the implementation of Nova.<br>
><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/baremetal/ironic/driver.py#L19" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>baremetal/ironic/driver.py#L19</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/console/websocketproxy.py#L17-L18" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>console/websocketproxy.py#L17-<wbr>L18</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/consoleauth/manager.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>consoleauth/manager.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/engine/configdrive.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>engine/configdrive.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/engine/metadata.py#L18" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>engine/metadata.py#L18</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/network/api.py#L18" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>network/api.py#L18</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/objects/aggregate.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>objects/aggregate.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/objects/keypair.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>objects/keypair.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/objects/server_fault.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>objects/server_fault.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/objects/server_group.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>objects/server_group.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/scheduler/client/report.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>scheduler/client/report.py#L17</a><br>
> <a href="https://github.com/openstack/mogan/blob/master/mogan/scheduler/filter_scheduler.py#L17" rel="noreferrer" target="_blank">https://github.com/openstack/<wbr>mogan/blob/master/mogan/<wbr>scheduler/filter_scheduler.py#<wbr>L17</a><br>
><br>
> 2. For the changes we follows what nova changed, should reference to the<br>
> original authors in the commit messages.<br>
><br>
><br>
> Please let me know if there are something else we need to do or there are<br>
> already some existing principles we can follow, thanks!<br>
><br>
><br>
><br>
> [1] <a href="https://wiki.openstack.org/wiki/Mogan" rel="noreferrer" target="_blank">https://wiki.openstack.org/<wbr>wiki/Mogan</a><br>
><br>
><br>
> --<br>
> Best Regards,<br>
> Zhenguo Niu<br>
><br>
</div></div>> ______________________________<wbr>______________________________<wbr>______________<br>
> OpenStack Development Mailing List (not for usage questions)<br>
> Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
> <a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
><br>
<span class="HOEnZb"><font color="#888888"><br>
<br>
<br>
--<br>
Davanum Srinivas :: <a href="https://twitter.com/dims" rel="noreferrer" target="_blank">https://twitter.com/dims</a><br>
<br>
______________________________<wbr>______________________________<wbr>______________<br>
OpenStack Development Mailing List (not for usage questions)<br>
Unsubscribe: <a href="http://OpenStack-dev-request@lists.openstack.org?subject:unsubscribe" rel="noreferrer" target="_blank">OpenStack-dev-request@lists.<wbr>openstack.org?subject:<wbr>unsubscribe</a><br>
<a href="http://lists.openstack.org/cgi-bin/mailman/listinfo/openstack-dev" rel="noreferrer" target="_blank">http://lists.openstack.org/<wbr>cgi-bin/mailman/listinfo/<wbr>openstack-dev</a><br>
</font></span></blockquote></div><br></div>